Skip to content

gitk: override PATH search only on Windows

Mark Levedahl git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v11 patch 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gitk: override $PATH search only on Windowsgitk+58 -880 replies
2/3gitk: _search_exe is no longer neededgitk+2 -30 replies
3/3gitk: limit PATH search to bare executable namesgitk+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] gitk: override PATH search only on Windows

Restrict overrides of exec/open to Windows only, as
the need for this is Tcl adding the current working directory to $PATH on Windows. Recent modifications to this render gitk unusable on Cygwin, isolating these overrides to Windows only both fixes that breakage andk reduces the liklihood of similar issues in the future.

patch summary:
1 - modifies the existing code to restrict the overrides
to Windows, restoring other platorms to native exec/open.
2 - remove now superflous variable _search_exe.
3 - fix the override code to avoid path search given a
relative path like foo/bar.

---
Changes since v1 - fixed commit ID reference for git-gui, otherwise
improved commit message in patch 1. Added patches 2 and 3.

Mark Levedahl (3):
gitk: override $PATH search only on Windows
gitk: _search_exe is no longer needed
gitk: limit PATH search to bare executable names

 gitk | 147 +++++++++++++++++++++++------------------------------------
 1 file changed, 58 insertions(+), 89 deletions(-)
Signature · 1 line
2.49.0.99.31