Skip to content

centralize base code handling for drivers

Bruce Richardson dpdk-dev 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 0 repliesNew
  2. v110 patches 11 repliesSuperseded

Changes in v2 from the cover letter

* rebase on latest main
* fix inclusion of accident diff in v1

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10build: add generic support for base code in driversdrivers/meson.build+20 -00 replies
2/10common/sfc_efx: use common base code build handlingdrivers/common/sfc_efx/base/meson.build drivers/common/sfc_efx/meson.build+3 -180 replies
3/10net/hinic: use common base code build handlingdrivers/net/hinic/base/meson.build drivers/net/hinic/meson.build+5 -120 replies
4/10net/intel: use common base code build handlingdrivers/net/intel/e1000/meson.build drivers/net/intel/fm10k/meson.build drivers/net/intel/i40e/meson.build +5 more+3 -250 replies
5/10net/ngbe: use common base code build handlingdrivers/net/ngbe/base/meson.build drivers/net/ngbe/meson.build+2 -130 replies
6/10net/octeontx: use common base code build handlingdrivers/net/octeontx/base/meson.build drivers/net/octeontx/meson.build+1 -210 replies
7/10net/qede: use common base code build handlingdrivers/net/qede/base/meson.build drivers/net/qede/meson.build+5 -130 replies
8/10net/thunderx: use common base code build handlingdrivers/net/thunderx/base/meson.build drivers/net/thunderx/meson.build+1 -120 replies
9/10net/txgbe: use common base code build handlingdrivers/net/txgbe/base/meson.build drivers/net/txgbe/meson.build+2 -190 replies
10/10raw/ifpga: use common base code build handlingdrivers/raw/ifpga/base/meson.build drivers/raw/ifpga/meson.build+14 -220 replies

Reviews trailers per patch

2 of 10 patches have a Reviewed-by or Acked-by.

PatchAndrew RybchenkoRosen Xu
1/10
2/10A-b
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] centralize base code handling for drivers

Many DPDK drivers use the same pattern for base code handling, having a meson.build file in the base code directory which optionally defines some custom cflags for the base code build, then builds the code as a static library and extracts the objects from it. (The reason behind this is that, in meson, cflags apply per-object, so we need to have a separate build object for the base code to use custom flags)

This patchset deduplicates this logic by putting it into the drivers/meson.build file, and allowing individual drivers to then just specify values for "base_sources" and "base_cflags".

v2:
* rebase on latest main
* fix inclusion of accident diff in v1

Bruce Richardson (10):
build: add generic support for base code in drivers common/sfc_efx: use common base code build handling net/hinic: use common base code build handling net/intel: use common base code build handling net/ngbe: use common base code build handling net/octeontx: use common base code build handling net/qede: use common base code build handling net/thunderx: use common base code build handling net/txgbe: use common base code build handling raw/ifpga: use common base code build handling

 drivers/common/sfc_efx/base/meson.build | 18 +++---------------
 drivers/common/sfc_efx/meson.build      |  3 ---
 drivers/meson.build                     | 20 ++++++++++++++++++++
 drivers/net/hinic/base/meson.build      | 16 +++++-----------
 drivers/net/hinic/meson.build           |  1 -
 drivers/net/intel/e1000/meson.build     |  3 ---
 drivers/net/intel/fm10k/meson.build     |  3 ---
 drivers/net/intel/i40e/meson.build      |  2 --
 drivers/net/intel/iavf/meson.build      |  1 -
 drivers/net/intel/ice/base/meson.build  | 13 +++----------
 drivers/net/intel/ice/meson.build       |  2 --
 drivers/net/intel/idpf/meson.build      |  1 -
 drivers/net/intel/ixgbe/meson.build     |  3 ---
 drivers/net/ngbe/base/meson.build       | 12 ++----------
 drivers/net/ngbe/meson.build            |  3 ---
 drivers/net/octeontx/base/meson.build   | 19 +------------------
 drivers/net/octeontx/meson.build        |  3 ---
 drivers/net/qede/base/meson.build       | 17 +++++------------
 drivers/net/qede/meson.build            |  1 -
 drivers/net/thunderx/base/meson.build   | 10 +---------
 drivers/net/thunderx/meson.build        |  3 ---
 drivers/net/txgbe/base/meson.build      | 18 ++----------------
 drivers/net/txgbe/meson.build           |  3 ---
 drivers/raw/ifpga/base/meson.build      | 21 ++-------------------
 drivers/raw/ifpga/meson.build           | 15 ++++++++++++---
 25 files changed, 56 insertions(+), 155 deletions(-)

--
2.45.2