Skip to content

net: make memory provider install / close paths more common

Jakub Kicinski netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyApplied 2/2
  2. v12 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- [patch 1] add to commit msg
- [patch 1] fix arg naming in the header
- [patch 2] don't split the registration check, it may cause a race if we just bail on the registration state and not on the MP being present, as we drop and re-take the instance lock after setting reg_state
v1: https://lore.kernel.org/[email protected]

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2net: move mp dev config validation to __net_mp_open_rxq()include/net/page_pool/memory_provider.h net/core/devmem.c net/core/netdev-genl.c +1 more+55 -580 repliesApplied
2/2net: avoid false positive warnings in __net_mp_close_rxq()net/core/devmem.c net/core/netdev_rx_queue.c+8 -81 replyApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMina AlmasryStanislav Fomichev
1/2R-b A-b
2/2R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net v2 0/2] net: make memory provider install / close paths more common

We seem to be fixing bugs in config path for devmem which also exist in the io_uring ZC path. Let's try to make the two paths more common, otherwise this is bound to keep happening.

Found by code inspection and compile tested only.

v2:
- [patch 1] add to commit msg
- [patch 1] fix arg naming in the header
- [patch 2] don't split the registration check, it may cause a race if we just bail on the registration state and not on the MP being present, as we drop and re-take the instance lock after setting reg_state
v1: https://lore.kernel.org/[email protected]

Jakub Kicinski (2):
net: move mp dev config validation to __net_mp_open_rxq()
net: avoid false positive warnings in __net_mp_close_rxq()

 include/net/page_pool/memory_provider.h |  6 +++
 net/core/devmem.c                       | 64 +++++++------------------
 net/core/netdev-genl.c                  |  6 ---
 net/core/netdev_rx_queue.c              | 53 +++++++++++++++-----
 4 files changed, 63 insertions(+), 66 deletions(-)
Signature · 1 line
2.49.0