Skip to content

drm/panel: make prepare / enable / disable / unprepare return void

Dmitry Baryshkov dri-devel lkml 1 version Applied

Status from this message: Applied to drm-misc-next, thanks!

Get series with b4
b4 am [email protected] change-id 20250401-panel-return-void-d461c71ebd35

Versions newest first

  1. v1 Latest7 patches 19 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7drm/bridge: analogix_dp: drop extra calls to analogix_dp_prepare_panel()drivers/gpu/drm/bridge/analogix/analogix_dp_core.c+1 -214 replies
2/7drm/bridge: analogix_dp: drop unused argument to analogix_dp_prepare_panel()drivers/gpu/drm/bridge/analogix/analogix_dp_core.c+5 -142 replies
3/7drm/bridge: analogic_dp: drop panel_is_modesetdrivers/gpu/drm/bridge/analogix/analogix_dp_core.c drivers/gpu/drm/bridge/analogix/analogix_dp_core.h+1 -114 replies
4/7drm/bridge: analogic_dp: drop panel_lockdrivers/gpu/drm/bridge/analogix/analogix_dp_core.c drivers/gpu/drm/bridge/analogix/analogix_dp_core.h+0 -72 replies
5/7drm/bridge: analogix_dp: inline analogix_dp_prepare_panel()drivers/gpu/drm/bridge/analogix/analogix_dp_core.c+10 -332 replies
6/7drm/bridge: analogix_dp: ignore return values of drm_panel_* callsdrivers/gpu/drm/bridge/analogix/analogix_dp_core.c+6 -332 replies
7/7drm/panel: make prepare/enable and disable/unprepare calls return voiddrivers/gpu/drm/drm_panel.c drivers/gpu/drm/panel/panel-newvision-nv3051d.c include/drm/drm_panel.h+26 -451 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchNeil ArmstrongDamon Ding
1/7R-b T-b
2/7R-b T-b
3/7R-b T-b
4/7R-b T-b
5/7R-b T-b
6/7R-b T-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] drm/panel: make prepare / enable / disable / unprepare return void

While it makes sense for panel callbacks to be able to return an error, the state-management functions from drm_panel API are usually called from atomic callbacks, which can not fails and must return void. Make drm_panel_prepare(), drm_panel_enable(), drm_panel_disable() and drm_panel_unprepare() follow the same calling convention and return void.

---
Dmitry Baryshkov (7):
drm/bridge: analogix_dp: drop extra calls to analogix_dp_prepare_panel() drm/bridge: analogix_dp: drop unused argument to analogix_dp_prepare_panel() drm/bridge: analogic_dp: drop panel_is_modeset
drm/bridge: analogic_dp: drop panel_lock
drm/bridge: analogix_dp: inline analogix_dp_prepare_panel() drm/bridge: analogix_dp: ignore return values of drm_panel_* calls drm/panel: make prepare/enable and disable/unprepare calls return void

 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 107 ++-------------------
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.h |   3 -
 drivers/gpu/drm/drm_panel.c                        |  54 ++++-------
 drivers/gpu/drm/panel/panel-newvision-nv3051d.c    |   9 +-
 include/drm/drm_panel.h                            |   8 +-
 5 files changed, 33 insertions(+), 148 deletions(-)

---
base-commit: bfb20a655848a9088e3e9ae24b1dcce1bbf016c2
change-id: 20250401-panel-return-void-d461c71ebd35

Best regards,

Signature · 1 line
Dmitry Baryshkov <[email protected]>