Skip to content

RFC Simplify OCI configuration menu

[email protected] kdevops 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest31 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/31terraform/OCI: Remove terraform_oci_instance_display_nameplaybooks/roles/gen_tfvars/defaults/main.yml playbooks/roles/gen_tfvars/templates/oci/terraform.tfvars.j2 terraform/oci/vars.tf+0 -70 replies
2/31terraform/OCI: One default value to rule themplaybooks/roles/gen_tfvars/defaults/main.yml terraform/oci/vars.tf+21 -390 replies
3/31terraform/OCI: Add an "Identity & Access" submenuterraform/oci/Kconfig terraform/oci/kconfigs/Kconfig.identity+31 -280 replies
4/31terraform/OCI: Add a "Resource location" submenuterraform/oci/Kconfig terraform/oci/kconfigs/Kconfig.location+23 -210 replies
5/31terraform/OCI: Add a "Compute" Kconfig submenuterraform/oci/Kconfig terraform/oci/kconfigs/Kconfig.compute+28 -260 replies
6/31terraform/OCI: Add a "Storage" Kconfig submenuterraform/oci/Kconfig terraform/oci/kconfigs/Kconfig.storage+3 -2140 replies
7/31terraform/OCI: Add a "Networking" Kconfig submenuterraform/oci/Kconfig terraform/oci/kconfigs/Kconfig.network+17 -150 replies
8/31terraform/OCI: Use "output yaml" for the tenancy OCIDscripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.identity+6 -50 replies
9/31terraform/OCI: Use "output yaml" for the user OCIDscripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.identity+5 -40 replies
10/31terraform/OCI: Use "output yaml" for the signing keyscripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.identity+7 -50 replies
11/31terraform/OCI: Use "output yaml" for the fingerprintscripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.identity+5 -50 replies
12/31terraform/OCI: Add a Region selectorscripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.location+48 -60 replies
13/31terraform/OCI: Add an availability domain selectorplaybooks/roles/gen_tfvars/templates/oci/terraform.tfvars.j2 scripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.location +10 more+270 -310 replies
14/31terraform/OCI: Select your compartment by name instead of by OCIDplaybooks/roles/gen_tfvars/templates/oci/terraform.tfvars.j2 scripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.location +2 more+23 -170 replies
15/31terraform/OCI: Use "output yaml" for the instance shape settingscripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.compute+1 -10 replies
16/31terraform/OCI: Add a shape selector for Flex shapesterraform/oci/kconfigs/Kconfig.compute terraform/oci/kconfigs/shapes/Kconfig.flex+86 -190 replies
17/31terraform/OCI: Use "output yaml" for the OCPUs settingscripts/terraform.Makefile terraform/oci/kconfigs/shapes/Kconfig.flex+14 -30 replies
18/31terraform/OCI: Use "output yaml" for the memory_in_gbs settingscripts/terraform.Makefile terraform/oci/kconfigs/shapes/Kconfig.flex+5 -30 replies
19/31terraform/OCI: Add a shape family selectorterraform/oci/kconfigs/Kconfig.compute terraform/oci/kconfigs/shapes/Kconfig.flex+27 -00 replies
20/31terraform/OCI: Add a bare metal shape selectorplaybooks/roles/gen_tfvars/templates/oci/terraform.tfvars.j2 terraform/oci/kconfigs/Kconfig.compute terraform/oci/kconfigs/shapes/Kconfig.bm+96 -00 replies
21/31terraform/OCI: Use "output yaml" for the source image settingscripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.compute+2 -20 replies
22/31terraform/OCI: Simplify image selectionterraform/oci/kconfigs/Kconfig.compute terraform/oci/kconfigs/images/Kconfig.OracleLinux terraform/oci/kconfigs/images/Kconfig.Ubuntu +1 more+456 -60 replies
23/31terraform/OCI: Remove TERRAFORM_OCI_VOLUMES_ENABLE_EXTRAplaybooks/roles/gen_tfvars/templates/oci/terraform.tfvars.j2 scripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.storage +2 more+17 -1340 replies
24/31terraform/OCI: Use "output yaml" for the assign_public_ip" settingplaybooks/roles/gen_tfvars/defaults/main.yml playbooks/roles/gen_tfvars/templates/oci/terraform.tfvars.j2 scripts/terraform.Makefile +1 more+7 -110 replies
25/31terraform/OCI: Use "output yaml" for the subnet_ocid settingscripts/terraform.Makefile terraform/oci/kconfigs/Kconfig.network+8 -70 replies
26/31terraform/OCI: Add a default VCNterraform/oci/main.tf+112 -00 replies
27/31terraform/OCI: Add a Kconfig switch to create a VCN on the flyplaybooks/roles/gen_tfvars/defaults/main.yml playbooks/roles/gen_tfvars/templates/oci/terraform.tfvars.j2 terraform/oci/kconfigs/Kconfig.network +2 more+51 -100 replies
28/31terraform/OCI: Run "terraform fmt" on provider.tfterraform/oci/provider.tf+5 -50 replies
29/31terraform/OCI: Run "terraform fmt" on main.tfterraform/oci/main.tf+2 -20 replies
30/31terraform/OCI: Nit: alphabetize vars.tfterraform/oci/vars.tf+48 -480 replies
31/31terraform/OCI: Update the OCI section of docs/kdevops-terraform.mddocs/kdevops-terraform.md+35 -820 replies

Reviews trailers per patch

None of the 31 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLuis ChamberlainChandan Babu R
SeriesR-b R-b
1/31
2/31
3/31
4/31
5/31
6/31
7/31
8/31
9/31
10/31
11/31
12/31
13/31
14/31
15/31
16/31
17/31
18/31
19/31
20/31
21/31
22/31
23/31
24/31
25/31
26/31
27/31
28/31
29/31
30/31
31/31

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/31] Simplify OCI configuration menu

From: Chuck Lever <[email protected]>

Over the past month or two I've had to set up kdevops with all four major public cloud providers in order to test the new volume_group role on each of them. There are a lot of similarities amongst the providers, and one of them is that set-up is probably much more complicated than necessary for all of them.

I've come up with some simplifications that can apply to all of the providers, but I'd like to start with OCI because it looks to me like it's the one that has the most users currently. Let's figure out what OCI configuration needs to look like (ie, what changes its users will tolerate!) and make the other providers work the same way.

This series features a number of changes:

- The configuration is split into several submenus, just like the cloud console, to help humans navigate the complexity

- A number of internal simplifications will help us keep up with changes and new features in the provider. In particular, splitting things into smaller files will make it simpler to add scripts to poll provider feature changes and adjust the kdevops menus accordingly

- Free-form strings and "copy this OCID from the console" are replaced with "choose from this menu of known-working options". This includes selection of region, availability domain, shape, and source image

- I've added an option to provision a VCN instead of assuming a pre-existing one, similar to how the other providers work

Some of this stuff will make immediate sense, and some might be controversial. All comments are welcome.

https://github.com/chucklever/kdevops branch => terraform-oci

Chuck Lever (31):
terraform/OCI: Remove terraform_oci_instance_display_name terraform/OCI: One default value to rule them terraform/OCI: Add an "Identity & Access" submenu terraform/OCI: Add a "Resource location" submenu terraform/OCI: Add a "Compute" Kconfig submenu terraform/OCI: Add a "Storage" Kconfig submenu terraform/OCI: Add a "Networking" Kconfig submenu terraform/OCI: Use "output yaml" for the tenancy OCID terraform/OCI: Use "output yaml" for the user OCID terraform/OCI: Use "output yaml" for the signing key terraform/OCI: Use "output yaml" for the fingerprint terraform/OCI: Add a Region selector
terraform/OCI: Add an availability domain selector terraform/OCI: Select your compartment by name instead of by OCID terraform/OCI: Use "output yaml" for the instance shape setting terraform/OCI: Add a shape selector for Flex shapes terraform/OCI: Use "output yaml" for the OCPUs setting terraform/OCI: Use "output yaml" for the memory_in_gbs setting terraform/OCI: Add a shape family selector terraform/OCI: Add a bare metal shape selector terraform/OCI: Use "output yaml" for the source image setting terraform/OCI: Simplify image selection
terraform/OCI: Remove TERRAFORM_OCI_VOLUMES_ENABLE_EXTRA terraform/OCI: Use "output yaml" for the assign_public_ip" setting terraform/OCI: Use "output yaml" for the subnet_ocid setting terraform/OCI: Add a default VCN
terraform/OCI: Add a Kconfig switch to create a VCN on the fly terraform/OCI: Run "terraform fmt" on provider.tf terraform/OCI: Run "terraform fmt" on main.tf terraform/OCI: Nit: alphabetize vars.tf
terraform/OCI: Update the OCI section of docs/kdevops-terraform.md

 docs/kdevops-terraform.md                     | 117 +++----
 playbooks/roles/gen_tfvars/defaults/main.yml  |  20 +-
 .../templates/oci/terraform.tfvars.j2         |  20 +-
 scripts/terraform.Makefile                    |  31 --
 terraform/oci/Kconfig                         | 289 +-----------------
 terraform/oci/kconfigs/Kconfig.compute        |  72 +++++
 terraform/oci/kconfigs/Kconfig.identity       |  35 +++
 terraform/oci/kconfigs/Kconfig.location       |  52 ++++
 terraform/oci/kconfigs/Kconfig.network        |  39 +++
 terraform/oci/kconfigs/Kconfig.storage        | 137 +++++++++
 .../oci/kconfigs/images/Kconfig.OracleLinux   | 237 ++++++++++++++
 terraform/oci/kconfigs/images/Kconfig.Ubuntu  | 162 ++++++++++
 terraform/oci/kconfigs/images/Kconfig.custom  |  20 ++
 .../kconfigs/regions/Kconfig.ap-hyderabad-1   |  28 ++
 .../oci/kconfigs/regions/Kconfig.ap-mumbai-1  |  27 ++
 .../kconfigs/regions/Kconfig.ca-montreal-1    |  28 ++
 .../oci/kconfigs/regions/Kconfig.ca-toronto-1 |  28 ++
 .../oci/kconfigs/regions/Kconfig.us-ashburn-1 |  36 +++
 .../oci/kconfigs/regions/Kconfig.us-chicago-1 |  36 +++
 .../oci/kconfigs/regions/Kconfig.us-phoenix-1 |  36 +++
 .../oci/kconfigs/regions/Kconfig.us-sanjose-1 |  28 ++
 terraform/oci/kconfigs/shapes/Kconfig.bm      |  83 +++++
 terraform/oci/kconfigs/shapes/Kconfig.flex    | 104 +++++++
 terraform/oci/main.tf                         | 195 +++++++++---
 terraform/oci/provider.tf                     |  10 +-
 terraform/oci/vars.tf                         | 158 +++++-----
 26 files changed, 1472 insertions(+), 556 deletions(-)
 create mode 100644 terraform/oci/kconfigs/Kconfig.compute
 create mode 100644 terraform/oci/kconfigs/Kconfig.identity
 create mode 100644 terraform/oci/kconfigs/Kconfig.location
 create mode 100644 terraform/oci/kconfigs/Kconfig.network
 create mode 100644 terraform/oci/kconfigs/Kconfig.storage
 create mode 100644 terraform/oci/kconfigs/images/Kconfig.OracleLinux
 create mode 100644 terraform/oci/kconfigs/images/Kconfig.Ubuntu
 create mode 100644 terraform/oci/kconfigs/images/Kconfig.custom
 create mode 100644 terraform/oci/kconfigs/regions/Kconfig.ap-hyderabad-1
 create mode 100644 terraform/oci/kconfigs/regions/Kconfig.ap-mumbai-1
 create mode 100644 terraform/oci/kconfigs/regions/Kconfig.ca-montreal-1
 create mode 100644 terraform/oci/kconfigs/regions/Kconfig.ca-toronto-1
 create mode 100644 terraform/oci/kconfigs/regions/Kconfig.us-ashburn-1
 create mode 100644 terraform/oci/kconfigs/regions/Kconfig.us-chicago-1
 create mode 100644 terraform/oci/kconfigs/regions/Kconfig.us-phoenix-1
 create mode 100644 terraform/oci/kconfigs/regions/Kconfig.us-sanjose-1
 create mode 100644 terraform/oci/kconfigs/shapes/Kconfig.bm
 create mode 100644 terraform/oci/kconfigs/shapes/Kconfig.flex
Signature · 1 line
2.48.1