Skip to content

drm/udl: Support adapters without vendor firmware descriptor

Thomas Zimmermann dri-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 0 repliesNew
  2. v19 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/udl: Remove unused field dev from struct udl_devicedrivers/gpu/drm/udl/udl_drv.h+0 -10 replies
2/9drm/udl: Remove unused field gem_lock from struct udl_devicedrivers/gpu/drm/udl/udl_drv.h drivers/gpu/drm/udl/udl_main.c+0 -40 replies
3/9drm/udl: Improve type safety when using struct udl_devicedrivers/gpu/drm/udl/udl_drv.c drivers/gpu/drm/udl/udl_drv.h drivers/gpu/drm/udl/udl_main.c +2 more+37 -360 replies
4/9drm/udl: The number of pixels is always positivedrivers/gpu/drm/udl/udl_drv.h+2 -20 replies
5/9drm/udl: Handle errors from usb_get_descriptor()drivers/gpu/drm/udl/udl_main.c+14 -100 replies
6/9drm/udl: Return error if vendor descriptor is too shortdrivers/gpu/drm/udl/udl_main.c+36 -360 replies
7/9drm/udl: Treat vendor descriptor as u8drivers/gpu/drm/udl/udl_main.c+8 -80 replies
8/9drm/udl: Validate length in vendor-descriptor parserdrivers/gpu/drm/udl/udl_main.c+51 -260 replies
9/9drm/udl: Support adapters without firmware descriptordrivers/gpu/drm/udl/udl_main.c+21 -160 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchPatrik Jakobsson
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] drm/udl: Support adapters without vendor firmware descriptor

Fallback to default values for devices without vendor firmware descriptor. Enables support for such devices. Since we're at it, improve the descriptor parser.

Patches 1 to 3 do some cleanups for the driver.

Patches 4 to 8 rewrite the parser code for the vendor firmware descriptor. It's now more compatible and validates the raw input more reliably.

Patch 9 adds support for the additional devices.

Tested with various DisplayLink adapters, including one without vendor firmware descriptor.

Thomas Zimmermann (9):
drm/udl: Remove unused field dev from struct udl_device drm/udl: Remove unused field gem_lock from struct udl_device drm/udl: Improve type safety when using struct udl_device drm/udl: The number of pixels is always positive drm/udl: Handle errors from usb_get_descriptor() drm/udl: Return error if vendor descriptor is too short drm/udl: Treat vendor descriptor as u8
drm/udl: Validate length in vendor-descriptor parser drm/udl: Support adapters without firmware descriptor

 drivers/gpu/drm/udl/udl_drv.c      |   6 +-
 drivers/gpu/drm/udl/udl_drv.h      |  19 ++--
 drivers/gpu/drm/udl/udl_main.c     | 174 +++++++++++++++++------------
 drivers/gpu/drm/udl/udl_modeset.c  |  21 ++--
 drivers/gpu/drm/udl/udl_transfer.c |   6 +-
 5 files changed, 128 insertions(+), 98 deletions(-)
Signature · 1 line
2.49.0