KVM: arm64: Fixes for resolving the fault IPA
Status from this message: Applied to fixes, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 5 repliesApplied
- v13 patches 6 repliesSuperseded
Changes in v2 from the cover letter
- Drop section reference in favor of the rule for HPFAR_EL2 validity
- Fold test for Address size fault into helper, reuse existing definitions
- Get rid of 'magic' shift for transforming FIPA field to an actual IPA
- Add BUG_ON() to handle_host_mem_abort() if we fail to resolve the fault IPA.
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | KVM: arm64: Only read HPFAR_EL2 when value is architecturally validarch/ arch/ | +48 | 3 replies | |
| 2/3 | arm64: Convert HPFAR_EL2 to sysreg tablearch/ arch/ arch/ | +11 | 0 replies | |
| 3/3 | KVM: arm64: Don't translate FAR if invalid/unsafearch/ arch/ arch/ +3 more | +73 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Marc Zyngier |
|---|---|
| Series | R-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/3] KVM: arm64: Fixes for resolving the fault IPA
KVM's heuristics for determining the fault IPA are a bit shaky and don't necessarily align with the letter of the architecture. On top of that, HPFAR_EL2 is UNKNOWN if an SEA occurred during a table walk. Re-walking the page tables will replay the SEA at EL2, becoming a panic in the hyp.
v1: https://lore.kernel.org/kvmarm/[email protected]/
v1 -> v2 (addressed Marc's feedback):
- Drop section reference in favor of the rule for HPFAR_EL2 validity
- Fold test for Address size fault into helper, reuse existing definitions
- Get rid of 'magic' shift for transforming FIPA field to an actual IPA
- Add BUG_ON() to handle_host_mem_abort() if we fail to resolve the fault IPA.
Oliver Upton (3):
KVM: arm64: Only read HPFAR_EL2 when value is architecturally valid
arm64: Convert HPFAR_EL2 to sysreg table
KVM: arm64: Don't translate FAR if invalid/unsafe
arch/arm64/include/asm/esr.h | 44 +++++++++++++++- arch/arm64/include/asm/kvm_emulate.h | 7 ++- arch/arm64/include/asm/kvm_ras.h | 2 +- arch/arm64/kvm/hyp/include/hyp/fault.h | 70 ++++++++++++++++++-------- arch/arm64/kvm/hyp/nvhe/mem_protect.c | 9 +++- arch/arm64/kvm/mmu.c | 31 +++++++----- arch/arm64/tools/sysreg | 7 +++ 7 files changed, 131 insertions(+), 39 deletions(-)
base-commit: 369c0122682c4468a69f2454614eded71c5348f3
Signature · 1 line
2.39.5