Skip to content

kbuild: resurrect generic header check facility

Jani Nikula dri-devel intel-gfx intel-xe linux-kbuild lkml 1 version NAK

Status from this message: NACK.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest4 patches 9 repliesNAK

Patches in v2

#Subject and filesSizeRepliesApplied
1/4kbuild: add generic header check facilityinit/Kconfig scripts/Makefile.build scripts/Makefile.lib+45 -00 replies
2/4drm: switch to generic header check facilitydrivers/gpu/drm/Kconfig drivers/gpu/drm/Makefile include/drm/Makefile+3 -290 replies
3/4drm/i915: switch to generic header check facilitydrivers/gpu/drm/i915/Makefile+2 -120 replies
4/4drm/xe: switch to generic header check facilitydrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_pcode_api.h+6 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] kbuild: resurrect generic header check facility

Another go at hiding the turds.

In v1 [1] I hid the build artifacts under .hdrtest subdirectories, one in each $(obj) directory, but the feedback from Linus [2] was to have one top level directory for this.

This is not possible without turning the whole thing back into a generic header check facility. Personally, I think this is a good thing. Just look at patches 2-4, it's great.

The main reason we've been doing this in the subsystem/driver level at all is the opposition from the kbuild maintainer. We'd very much like for Masahiro to support us in our efforts, but without that support, we're limited to hacking in the subsystem/driver Makefiles.

BR,
Jani.

[1] https://lore.kernel.org/r/[email protected]

[2] https://lore.kernel.org/r/CAHk-=wiP0ea7xq2P3ryYs6xGWoqTw1E4jha67ZbJkaFrjqUdkQ@mail.gmail.com

Jani Nikula (4):
kbuild: add generic header check facility
drm: switch to generic header check facility drm/i915: switch to generic header check facility drm/xe: switch to generic header check facility

 drivers/gpu/drm/Kconfig           |  2 +-
 drivers/gpu/drm/Makefile          | 15 +--------------
 drivers/gpu/drm/i915/Makefile     | 14 ++------------
 drivers/gpu/drm/xe/Makefile       | 10 ++--------
 drivers/gpu/drm/xe/xe_pcode_api.h |  4 ++++
 include/drm/Makefile              | 15 +--------------
 init/Kconfig                      | 25 +++++++++++++++++++++++++
 scripts/Makefile.build            | 13 +++++++++++++
 scripts/Makefile.lib              |  7 +++++++
 9 files changed, 56 insertions(+), 49 deletions(-)
Signature · 1 line
2.39.5