Skip to content

fix wrong hds-thresh value setting

Taehee Yoo linux-kselftest netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesApplied 2/2
  2. v12 patches 1 replySuperseded

Changes in v2 from the cover letter

- Skips set_hds_thresh_random test when hds-thresh-max value is too small. (2/2)
- Change random range from 1-MAX to 1-(MAX-1). (2/2)

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2net: ethtool: fix ethtool_ringparam_get_cfg() returns a hds_thresh value always as 0.net/ethtool/common.c+1 -00 repliesApplied
2/2selftests: drv-net: test random value for hds-threshtools/testing/selftests/drivers/net/hds.py+32 -10 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 net 0/2] fix wrong hds-thresh value setting

A hds-thresh value is not set correctly if input value is 0. The cause is that ethtool_ringparam_get_cfg(), which is a internal function that returns ringparameters from both ->get_ringparam() and dev->cfg can't return a correct hds-thresh value.

The first patch fixes ethtool_ringparam_get_cfg() to set hds-thresh value correcltly.

The second patch adds random test for hds-thresh value. So that we can test 0 value for a hds-thresh properly.

v2:
- Skips set_hds_thresh_random test when hds-thresh-max value is too small. (2/2)
- Change random range from 1-MAX to 1-(MAX-1). (2/2)

Taehee Yoo (2):
net: ethtool: fix ethtool_ringparam_get_cfg() returns a hds_thresh
value always as 0.
selftests: drv-net: test random value for hds-thresh

 net/ethtool/common.c                       |  1 +
 tools/testing/selftests/drivers/net/hds.py | 33 +++++++++++++++++++++-
 2 files changed, 33 insertions(+), 1 deletion(-)
Signature · 1 line
2.34.1