Skip to content

ocfs2: Fix deadlocks in quota recovery

Jan Kara ocfs2-devel 3 versions – Applied

Status from this message: [merged mm-hotfixes-stable] ocfs2-stop-quota-recovery-before-disabling-quotas.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesApplied 3/3
  2. v23 patches 5 repliesSuperseded
  3. v13 patches 8 repliesSuperseded

Changes in v3 from the cover letter

* Added Acked-by, Reviewed-by, Tested-by tags

Patches in v3 All 3 applied

#Subject and filesSizeRepliesApplied
1/3ocfs2: Switch osb->disable_recovery to enumfs/ocfs2/journal.c fs/ocfs2/ocfs2.h+14 -70 repliesApplied
2/3ocfs2: Implement handshaking with ocfs2 recovery threadfs/ocfs2/journal.c fs/ocfs2/ocfs2.h+39 -170 repliesApplied
3/3ocfs2: Stop quota recovery before disabling quotasfs/ocfs2/journal.c fs/ocfs2/journal.h fs/ocfs2/ocfs2.h +2 more+30 -90 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchHeming ZhaoJoseph Qi
1/3R-b T-b A-b
2/3R-b T-b A-b
3/3R-b T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] ocfs2: Fix deadlocks in quota recovery

Hello,

this implements another approach to fixing quota recovery deadlocks. We avoid grabbing sb->s_umount semaphore from ocfs2_finish_quota_recovery() and instead stop quota recovery early in ocfs2_dismount_volume(). Andrew, patches seem to be ready. Can you please merge them? Thanks!

Changes since v2:
* Added Acked-by, Reviewed-by, Tested-by tags

Changes since v1:
* added Hemming's Reviewed-by and Tested-by tags
* fixed __ocfs2_recovery_thread() state transition spotted by Hemming

Honza
Previous versions: