Skip to content

support SKF_NET_OFF and SKF_LL_OFF on skb frags

Willem de Bruijn bpf netdev 3 versions – Applied

Status from this message: This series was applied to bpf/bpf.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyApplied 2/2
  2. v22 patches 6 repliesSuperseded
  3. v12 patches 8 repliesSuperseded

Changes in v3 from the cover letter

- do not remove bpf_internal_load_pointer_neg_helper, because it is still used in the sparc32 JIT

Patches in v3 All 2 applied

#Subject and filesSizeRepliesApplied
1/2bpf: support SKF_NET_OFF and SKF_LL_OFF on skb fragsnet/core/filter.c+44 -361 replyApplied
2/2selftests/net: test sk_filter support for SKF_NET_OFF on fragstools/testing/selftests/net/.gitignore tools/testing/selftests/net/Makefile tools/testing/selftests/net/skf_net_off.c +1 more+277 -00 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchStanislav Fomichev
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH bpf v3 0/2] support SKF_NET_OFF and SKF_LL_OFF on skb frags

From: Willem de Bruijn <[email protected]>

Address a longstanding issue that may lead to missed packets depending on system configuration.

Ensure that reading from packet contents works regardless of skb geometry, also when using the special SKF_.. negative offsets to offset from L2 or L3 header.

Patch 2 is the selftest for the fix.

v2->v3
- do not remove bpf_internal_load_pointer_neg_helper, because it is still used in the sparc32 JIT

v1->v2
- introduce bfp_skb_load_helper_convert_offset to avoid open coding
- selftest: add comment why early demux must be disabled

v2: https://lore.kernel.org/netdev/[email protected]/
v1: https://lore.kernel.org/netdev/[email protected]/

Willem de Bruijn (2):
bpf: support SKF_NET_OFF and SKF_LL_OFF on skb frags selftests/net: test sk_filter support for SKF_NET_OFF on frags

 net/core/filter.c                          |  80 ++++---
 tools/testing/selftests/net/.gitignore     |   1 +
 tools/testing/selftests/net/Makefile       |   2 +
 tools/testing/selftests/net/skf_net_off.c  | 244 +++++++++++++++++++++
 tools/testing/selftests/net/skf_net_off.sh |  30 +++
 5 files changed, 321 insertions(+), 36 deletions(-)
 create mode 100644 tools/testing/selftests/net/skf_net_off.c
 create mode 100755 tools/testing/selftests/net/skf_net_off.sh
Signature · 1 line
2.49.0.504.g3bcea36a83-goog