Skip to content

hw/arm: GIC ITS=off ACPI tables fixes

Philippe Mathieu-Daudé qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest9 patches 20 repliesIn review

Changes in v3 from the cover letter

- Fixed no_tcg_its inverted logic (rth)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/arm/virt: Remove pointless VirtMachineState::tcg_its fieldhw/arm/virt.c include/hw/arm/virt.h+5 -91 reply
2/9hw/intc/gicv3_its: Do not check its_class_name() for NULLhw/arm/virt-acpi-build.c include/hw/intc/arm_gicv3_its_common.h+3 -31 reply
3/9hw/arm/virt: Simplify create_its()hw/arm/virt.c+3 -92 replies
4/9hw/arm/virt-acpi: Factor its_enabled() helper outhw/arm/virt-acpi-build.c+9 -31 reply
5/9qtest/bios-tables-test: Add test for -M virt,its=offtests/qtest/bios-tables-test.c+21 -02 replies
6/9qtest/bios-tables-test: Whitelist aarch64/virt 'its_off' variant blobstests/data/acpi/aarch64/virt/APIC.its_off tests/data/acpi/aarch64/virt/FACP.its_off tests/data/acpi/aarch64/virt/IORT.its_off +2 more+4 -08 replies
7/9hw/arm/virt-acpi: Always build IORT table (even with GIC ITS disabled)hw/arm/virt-acpi-build.c+21 -172 replies
8/9hw/arm/virt-acpi: Do not advertise disabled GIC ITShw/arm/virt-acpi-build.c+1 -10 replies
9/9qtest/bios-tables-test: Update aarch64/virt 'its_off' variant blobstests/data/acpi/aarch64/virt/APIC.its_off tests/data/acpi/aarch64/virt/IORT.its_off tests/qtest/bios-tables-test-allowed-diff.h+0 -31 reply

Reviews trailers per patch

6 of 9 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonGustavo RomeroEric Auger
1/9R-b
2/9R-b R-b
3/9R-b R-b R-b
4/9R-b R-b R-b
5/9
6/9R-b
7/9
8/9R-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH-for-10.1 v3 0/9] hw/arm: GIC ITS=off ACPI tables fixes

Since v2:
- Fixed no_tcg_its inverted logic (rth)

Fix ACPI tables for '-M its=off' CLI option.

Regards,

Phil.

Philippe Mathieu-Daudé (9):
hw/arm/virt: Remove pointless VirtMachineState::tcg_its field hw/intc/gicv3_its: Do not check its_class_name() for NULL hw/arm/virt: Simplify create_its()
hw/arm/virt-acpi: Factor its_enabled() helper out qtest/bios-tables-test: Add test for -M virt,its=off qtest/bios-tables-test: Whitelist aarch64/virt 'its_off' variant blobs hw/arm/virt-acpi: Always build IORT table (even with GIC ITS disabled) hw/arm/virt-acpi: Do not advertise disabled GIC ITS qtest/bios-tables-test: Update aarch64/virt 'its_off' variant blobs

 include/hw/arm/virt.h                     |   1 -
 include/hw/intc/arm_gicv3_its_common.h    |   2 +-
 hw/arm/virt-acpi-build.c                  |  48 +++++++++++++---------
 hw/arm/virt.c                             |  23 ++++-------
 tests/qtest/bios-tables-test.c            |  22 ++++++++++
 tests/data/acpi/aarch64/virt/APIC.its_off | Bin 0 -> 164 bytes
 tests/data/acpi/aarch64/virt/FACP.its_off | Bin 0 -> 276 bytes
 tests/data/acpi/aarch64/virt/IORT.its_off | Bin 0 -> 212 bytes
 8 files changed, 59 insertions(+), 37 deletions(-)
 create mode 100644 tests/data/acpi/aarch64/virt/APIC.its_off
 create mode 100644 tests/data/acpi/aarch64/virt/FACP.its_off
 create mode 100644 tests/data/acpi/aarch64/virt/IORT.its_off
Signature · 1 line
2.47.1