Skip to content

nft_set_pipapo: fix incorrect avx2 match of 5th field octet

Florian Westphal netfilter-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesIn review
  2. v23 patches 2 repliesSuperseded
  3. v13 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- reverse order, fix first, debug infra last
- fix and test are unchanged
- debug patch adds new 'last pass' to check that
all registers were processed.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nft_set_pipapo: fix incorrect avx2 match of 5th field octetnet/netfilter/nft_set_pipapo_avx2.c+2 -10 replies
2/3selftests: netfilter: add test case for recent mismatch bugtools/testing/selftests/net/netfilter/nft_concat_range.sh+38 -10 replies
3/3nft_set_pipapo: add avx register usage tracking for NET_DEBUG buildsnet/netfilter/nft_set_pipapo_avx2.c+269 -313 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchStefano Brivio
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 nf 0/3] nft_set_pipapo: fix incorrect avx2 match of 5th field octet

Sontu Mazumdar reports incorrect matching in the pipapo set type.

1st patch fixes the reported issue.
2nd patch adds a test case.
3rd patch adds debug infrastructure (conditional for CONFIG_DEBUG_NET) to add avx register tracking.

I checked that selftest passes with all three patches applied, that the new selftest fails without the fix and that the register tracking added in patch 1 also produces a WARN splat.

Changes since v2:
- reverse order, fix first, debug infra last
- fix and test are unchanged
- debug patch adds new 'last pass' to check that
all registers were processed.

Florian Westphal (3):
nft_set_pipapo: fix incorrect avx2 match of 5th field octet
selftests: netfilter: add test case for recent mismatch bug
nft_set_pipapo: add avx register usage tracking for NET_DEBUG builds

 net/netfilter/nft_set_pipapo_avx2.c           | 303 ++++++++++++++++--
 .../net/netfilter/nft_concat_range.sh         |  39 ++-
 2 files changed, 309 insertions(+), 33 deletions(-)
Signature · 1 line
2.49.0