Skip to content

ASoC: Intel: avs: 16 channels support

Cezary Rojewski linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8lib/string_helpers: Introduce parse_int_array()include/linux/string_helpers.h lib/string_helpers.c+22 -183 replies
2/8ALSA: hda: Allow for 16 channels configurationsound/hda/hdac_device.c+1 -11 reply
3/8ASoC: Intel: avs: Rename AVS_CHANNELS_MAX definesound/soc/intel/avs/messages.h sound/soc/intel/avs/path.c sound/soc/intel/avs/topology.h+4 -40 replies
4/8ASoC: Intel: avs: Allow for 16 channels configurationsound/soc/intel/avs/messages.h sound/soc/intel/avs/pcm.c+5 -40 replies
5/8ASoC: Intel: avs: Allow to specify custom configurations with i2s_testsound/soc/intel/avs/board_selection.c+68 -660 replies
6/8ASoC: Intel: avs: Assign unique ID to platform devicessound/soc/intel/avs/board_selection.c+7 -30 replies
7/8ASoC: Intel: avs: Iterate over correct number of TDMssound/soc/intel/avs/pcm.c+1 -10 replies
8/8ASoC: Intel: avs: Support 16 TDMs in dynamic assignmentsound/soc/intel/avs/topology.c+2 -20 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchAmadeusz SławińskiCezary RojewskiAndy Shevchenko
1/8R-b R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] ASoC: Intel: avs: 16 channels support

Relatively small delta-wise patchset which raises max channels supported from 8 to 16. The existing limitation is software-based, not hardware based. The hardware, as per HDAudio specification, section 1.2.2, (relevant register at SDnFMT, section 3.3.41) supports the configurations for years. The avs-driver becomes the first consumer of that configuration on the Linux kernel side.

Set starts off with update to string_helpers so that functionality added with parse_int_array_user() can be utilized in kernel-kernel interactions.

Follow up is rasing the cap on HDAudio-library side. The format selection procedure found in the library is good-to-go as is.

Everything that follows these two patches is avs-driver specific:
- raise channels_max for every DAI-driver template
- provide i2s_test module parameter for testing purposes. When combined with I2S loopback card, allows to test 16ch on most Intel hardware post Broadwell era
- adjust TDM masks to reflect the 8 -> 16 channels change

Amadeusz Sławiński (5):
ASoC: Intel: avs: Rename AVS_CHANNELS_MAX define
ASoC: Intel: avs: Allow to specify custom configurations with i2s_test
ASoC: Intel: avs: Assign unique ID to platform devices
ASoC: Intel: avs: Iterate over correct number of TDMs
ASoC: Intel: avs: Support 16 TDMs in dynamic assignment

Cezary Rojewski (3):
lib/string_helpers: Introduce parse_int_array()
ALSA: hda: Allow for 16 channels configuration
ASoC: Intel: avs: Allow for 16 channels configuration

 include/linux/string_helpers.h        |   1 +
 lib/string_helpers.c                  |  39 +++----
 sound/hda/hdac_device.c               |   2 +-
 sound/soc/intel/avs/board_selection.c | 144 ++++++++++++++------------
 sound/soc/intel/avs/messages.h        |   5 +-
 sound/soc/intel/avs/path.c            |   2 +-
 sound/soc/intel/avs/pcm.c             |  10 +-
 sound/soc/intel/avs/topology.c        |   4 +-
 sound/soc/intel/avs/topology.h        |   2 +-
 9 files changed, 110 insertions(+), 99 deletions(-)
Signature · 1 line
2.25.1