virtio: Call set_features during reset
Get series with b4
b4 am [email protected] change-id 20250406-reset-5ed5248ee3c1Versions newest first
- v2 Latest2 patches 0 repliesNew
- v11 patch 10 repliesSuperseded
Changes in v2 from the cover letter
- Described possible consequences without this fix.
- Extracted the change to move virtio_reset() into another patch.
- Link to v1: https://lore.kernel.org/qemu-devel/[email protected]
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | virtio: Call set_features during resethw/ | +3 | 0 replies | |
| 2/2 | virtio: Move virtio_reset()hw/ | +43 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/2] virtio: Call set_features during reset
virtio-net expects set_features() will be called when the feature set used by the guest changes to update the number of virtqueues but it is not called during reset, which will clear all features, leaving the queues added for VIRTIO_NET_F_MQ or VIRTIO_NET_F_RSS. Not only these extra queues are visible to the guest, they will cause segmentation fault during migration.
Call set_features() during reset to remove those queues for virtio-net as we call set_status(). It will also prevent similar bugs for virtio-net and other devices in the future.
---
Changes in v2:
- Described possible consequences without this fix.
- Extracted the change to move virtio_reset() into another patch.
- Link to v1: https://lore.kernel.org/qemu-devel/[email protected]
---
Akihiko Odaki (2):
virtio: Call set_features during reset
virtio: Move virtio_reset()
hw/virtio/virtio.c | 86 +++++++++++++++++++++++++++--------------------------- 1 file changed, 43 insertions(+), 43 deletions(-)
---
base-commit: 825b96dbcee23d134b691fc75618b59c5f53da32
change-id: 20250406-reset-5ed5248ee3c1
Best regards,
Signature · 1 line
Akihiko Odaki <[email protected]>