rxrpc, afs: Add AFS GSSAPI security class to AF_RXRPC and kafs
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest14 patches 0 repliesApplied 14/14
- v213 patches 6 repliesSuperseded
- v112 patches 3 repliesSuperseded
Patches in v3 All 14 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | rxrpc: kdoc: Update function descriptions and add link from rxrpc.rstDocumentation/ net/ net/ +4 more | +61 | 0 replies | Applied |
| 2/14 | rxrpc: Pull out certain app callback funcs into an ops tablefs/ include/ net/ +3 more | +55 | 0 replies | Applied |
| 3/14 | rxrpc: Remove some socket lock acquire/release annotationsnet/ net/ net/ | +5 | 0 replies | Applied |
| 4/14 | rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSEDocumentation/ fs/ fs/ +20 more | +1188 | 0 replies | Applied |
| 5/14 | rxrpc: Add the security index for yfs-rxgkfs/ include/ include/ | +63 | 0 replies | Applied |
| 6/14 | rxrpc: Add YFS RxGK (GSSAPI) security classinclude/ net/ | +202 | 0 replies | Applied |
| 7/14 | rxrpc: rxgk: Provide infrastructure and key derivationnet/ net/ net/ +2 more | +364 | 0 replies | Applied |
| 8/14 | rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)Documentation/ fs/ include/ +9 more | +1694 | 0 replies | Applied |
| 9/14 | rxrpc: rxgk: Implement connection rekeyinginclude/ net/ net/ +1 more | +181 | 0 replies | Applied |
| 10/14 | rxrpc: Allow the app to store private data on peer structsnet/ | +2 | 0 replies | Applied |
| 11/14 | rxrpc: Display security params in the afs_cb_call tracepointDocumentation/ fs/ fs/ +5 more | +41 | 0 replies | Applied |
| 12/14 | afs: Use rxgk RESPONSE to pass token for callback channelfs/ fs/ fs/ +2 more | +276 | 0 replies | Applied |
| 13/14 | rxrpc: Add more CHALLENGE/RESPONSE packet tracinginclude/ net/ net/ +1 more | +85 | 0 replies | Applied |
| 14/14 | rxrpc: rxperf: Add test RxGK server keysnet/ | +65 | 0 replies | Applied |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH net-next v3 00/14] rxrpc, afs: Add AFS GSSAPI security class to AF_RXRPC and kafs
Here's a set of patches to add basic support for the AFS GSSAPI security class to AF_RXRPC and kafs. It provides transport security for keys that match the security index 6 (YFS) for connections to the AFS fileserver and VL server.
Note that security index 4 (OpenAFS) can also be supported using this, but it needs more work as it's slightly different.
The patches also provide the ability to secure the callback channel - connections from the fileserver back to the client that are used to pass file change notifications, amongst other things. When challenged by the fileserver, kafs will generate a token specific to that server and include it in the RESPONSE packet as the appdata. The server then extracts this and uses it to send callback RPC calls back to the client.
It can also be used to provide transport security on the callback channel, but a further set of patches is required to provide the token and key to set that up when the client responds to the fileserver's challenge.
This makes use of the previously added crypto-krb5 library that is now upstream (last commit fc0cf10c04f4).
This series of patches consist of the following parts:
(0) Update kdoc comments to remove some kdoc builder warnings.
(1) Push reponding to CHALLENGE packets over to recvmsg() or the kernel equivalent so that the application layer can include user-defined information in the RESPONSE packet. In a follow-up patch set, this will allow the callback channel to be secured by the AFS filesystem.
(2) Add the AF_RXRPC RxGK security class that uses a key obtained from the AFS GSS security service to do Kerberos 5-based encryption instead of pcbc(fcrypt) and pcbc(des).
(3) Add support for callback channel encryption in kafs.
(4) Provide the test rxperf server module with some fixed krb5 keys.
David
The patches can be found on this branch also:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next
CHANGES
=======
ver #3)
- Fixed a leak in an error return path.
- Added a patch to remove/adjust some __acquires() and __releases() annotations to remove some checker warnings[*].
- Removed the additional __releases() notifications from oob.c.
[*] Note that lock_sock() and release_sock() should probably have some
sort of lock annotation so they can be checked.
ver #2)
- Fix use of %zx instead of %lx.
- Add a patch to add 'Return:' descriptions into existing kdoc comments.
- Add 'Return:' descriptions into new kdoc comments.
- Add a function API ref at the end of rxrpc.rst.
David Howells (14):
rxrpc: kdoc: Update function descriptions and add link from rxrpc.rst
rxrpc: Pull out certain app callback funcs into an ops table
rxrpc: Remove some socket lock acquire/release annotations
rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSE
rxrpc: Add the security index for yfs-rxgk
rxrpc: Add YFS RxGK (GSSAPI) security class
rxrpc: rxgk: Provide infrastructure and key derivation
rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)
rxrpc: rxgk: Implement connection rekeying
rxrpc: Allow the app to store private data on peer structs
rxrpc: Display security params in the afs_cb_call tracepoint
afs: Use rxgk RESPONSE to pass token for callback channel
rxrpc: Add more CHALLENGE/RESPONSE packet tracing
rxrpc: rxperf: Add test RxGK server keys
Documentation/networking/rxrpc.rst | 15 + fs/afs/Kconfig | 1 + fs/afs/Makefile | 1 + fs/afs/cm_security.c | 340 +++++++ fs/afs/internal.h | 20 + fs/afs/main.c | 1 + fs/afs/misc.c | 27 + fs/afs/rxrpc.c | 40 +- fs/afs/server.c | 2 + include/crypto/krb5.h | 5 + include/keys/rxrpc-type.h | 17 + include/net/af_rxrpc.h | 51 +- include/trace/events/afs.h | 11 +- include/trace/events/rxrpc.h | 163 +++- include/uapi/linux/rxrpc.h | 77 +- net/rxrpc/Kconfig | 23 + net/rxrpc/Makefile | 6 +- net/rxrpc/af_rxrpc.c | 93 +- net/rxrpc/ar-internal.h | 82 +- net/rxrpc/call_accept.c | 34 +- net/rxrpc/call_object.c | 24 +- net/rxrpc/conn_event.c | 134 ++- net/rxrpc/conn_object.c | 2 + net/rxrpc/insecure.c | 13 +- net/rxrpc/io_thread.c | 12 +- net/rxrpc/key.c | 187 ++++ net/rxrpc/oob.c | 379 ++++++++ net/rxrpc/output.c | 60 +- net/rxrpc/peer_object.c | 22 +- net/rxrpc/protocol.h | 20 + net/rxrpc/recvmsg.c | 132 ++- net/rxrpc/rxgk.c | 1367 ++++++++++++++++++++++++++++ net/rxrpc/rxgk_app.c | 285 ++++++ net/rxrpc/rxgk_common.h | 139 +++ net/rxrpc/rxgk_kdf.c | 288 ++++++ net/rxrpc/rxkad.c | 296 +++--- net/rxrpc/rxperf.c | 78 +- net/rxrpc/security.c | 3 + net/rxrpc/sendmsg.c | 25 +- net/rxrpc/server_key.c | 42 + 40 files changed, 4272 insertions(+), 245 deletions(-) create mode 100644 fs/afs/cm_security.c create mode 100644 net/rxrpc/oob.c create mode 100644 net/rxrpc/rxgk.c create mode 100644 net/rxrpc/rxgk_app.c create mode 100644 net/rxrpc/rxgk_common.h create mode 100644 net/rxrpc/rxgk_kdf.c