Add Microchip ZL3073x support (part 1)
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v13 Latest12 patches 8 repliesApplied 12/12
- v1214 patches 17 repliesSuperseded
- v1114 patches 10 repliesSuperseded
Earlier versions · 11
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v10 | 14 patches | 2 replies | Superseded | |
| v9 | 14 patches | 4 replies | Superseded | |
| v8 | 8 patches | 3 replies | Superseded | |
| v7 | 8 patches | 17 replies | Superseded | |
| v6 | 8 patches | 6 replies | Superseded | |
| v5 | 8 patches | 2 replies | Superseded | |
| v4 | 8 patches | 23 replies | Superseded | |
| v3 posting 2/2 | 8 patches | 30 replies | Superseded | |
| v3 posting 1/2 | 0 of 10 patches | 0 replies | Superseded | |
| v2 | 14 patches | 48 replies | Superseded | |
| v1 | 28 patches | 41 replies | Superseded |
Changes in v13 from the cover letter
* added support for u64 devlink parameters
* added support for generic devlink parameter 'clock_id'
* several patches squashed into one per @jpirko's advice
* renamed devlink version 'cfg.custom_ver' to 'custom_cfg'
* per discussion with @jpirko, the clock_id is now generated randomly and user have an option to change it via devlink
* implemented devlink reload to apply clock_id change
Patches in v13 All 12 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | dt-bindings: dpll: Add DPLL device and pinDocumentation/ Documentation/ MAINTAINERS | +123 | 0 replies | Applied |
| 2/12 | dt-bindings: dpll: Add support for Microchip Azurite chip familyDocumentation/ | +115 | 0 replies | Applied |
| 3/12 | devlink: Add support for u64 parametersinclude/ net/ | +12 | 0 replies | Applied |
| 4/12 | devlink: Add new "clock_id" generic device paramDocumentation/ include/ net/ | +12 | 0 replies | Applied |
| 5/12 | dpll: Add basic Microchip ZL3073x supportDocumentation/ Documentation/ MAINTAINERS +12 more | +1121 | 0 replies | Applied |
| 6/12 | dpll: zl3073x: Fetch invariants during probedrivers/ drivers/ drivers/ | +600 | 0 replies | Applied |
| 7/12 | dpll: zl3073x: Read DPLL types and pin properties from system firmwaredrivers/ drivers/ drivers/ +2 more | +437 | 0 replies | Applied |
| 8/12 | dpll: zl3073x: Register DPLL devices and pinsdrivers/ drivers/ drivers/ +4 more | +1156 | 0 replies | Applied |
| 9/12 | dpll: zl3073x: Implement input pin selection in manual modedrivers/ drivers/ | +124 | 0 replies | Applied |
| 10/12 | dpll: zl3073x: Add support to get/set priority on input pinsdrivers/ drivers/ | +89 | 0 replies | Applied |
| 11/12 | dpll: zl3073x: Implement input pin state setting in automatic modedrivers/ | +32 | 0 replies | Applied |
| 12/12 | dpll: zl3073x: Add support to get/set frequency on pinsdrivers/ drivers/ | +359 | 5 replies | Applied |
Reviews trailers per patch
4 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Krzysztof Kozlowski | Jiri Pirko |
|---|---|---|
| Series | R-b | |
| 1/12 | R-b | |
| 2/12 | R-b | |
| 3/12 | R-b | |
| 4/12 | R-b | |
| 5/12 | ||
| 6/12 | ||
| 7/12 | ||
| 8/12 | ||
| 9/12 | ||
| 10/12 | ||
| 11/12 | ||
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v13 00/12] Add Microchip ZL3073x support (part 1)
Add support for Microchip Azurite DPLL/PTP/SyncE chip family that provides DPLL and PTP functionality. This series bring first part that adds the core functionality and basic DPLL support.
The next part of the series will bring additional DPLL functionality like eSync support, phase offset and frequency offset reporting and phase adjustments.
Testing was done by myself and by Prathosh Satish on Microchip EDS2 development board with ZL30732 DPLL chip connected over I2C bus.
---
Changelog:
v13:
* added support for u64 devlink parameters
* added support for generic devlink parameter 'clock_id'
* several patches squashed into one per @jpirko's advice
* renamed devlink version 'cfg.custom_ver' to 'custom_cfg'
* per discussion with @jpirko, the clock_id is now generated randomly and user have an option to change it via devlink
* implemented devlink reload to apply clock_id change
v12:
* Using 'return dev_err_probe()'
* Separate zl3073x_chip_info structures instead of array
* Use mul_u64_u32_div() to compute input reference frequency to avoid potential overflow
* Removed superfluous check in zl3073x_dpll_output_pin_frequency_set()
v11:
* Fixed uninitialized 'rc' in error-path in patch 9
v10:
* Usage of str_enabled_disabled() where possible.
v9:
After discussion with Jakub Kicinski we agreed that it would be better to implement whole functionality in a single driver without touching MFD sub-system. Besides touching multiple sub-systems by single device there are also some technical issues that are easier resolvable in a single driver. Additionally the firmware flashing functionality would bring more than 1000 lines of code with previous approach to the MFD driver - it is not something the MFD maintainers would like to see.
Ivan Vecera (12):
dt-bindings: dpll: Add DPLL device and pin
dt-bindings: dpll: Add support for Microchip Azurite chip family
devlink: Add support for u64 parameters
devlink: Add new "clock_id" generic device param
dpll: Add basic Microchip ZL3073x support
dpll: zl3073x: Fetch invariants during probe
dpll: zl3073x: Read DPLL types and pin properties from system firmware
dpll: zl3073x: Register DPLL devices and pins
dpll: zl3073x: Implement input pin selection in manual mode
dpll: zl3073x: Add support to get/set priority on input pins
dpll: zl3073x: Implement input pin state setting in automatic mode
dpll: zl3073x: Add support to get/set frequency on pins
.../devicetree/bindings/dpll/dpll-device.yaml | 76 + .../devicetree/bindings/dpll/dpll-pin.yaml | 45 + .../bindings/dpll/microchip,zl30731.yaml | 115 ++ .../networking/devlink/devlink-params.rst | 3 + Documentation/networking/devlink/index.rst | 1 + Documentation/networking/devlink/zl3073x.rst | 51 + MAINTAINERS | 10 + drivers/Kconfig | 4 +- drivers/dpll/Kconfig | 6 + drivers/dpll/Makefile | 2 + drivers/dpll/zl3073x/Kconfig | 36 + drivers/dpll/zl3073x/Makefile | 10 + drivers/dpll/zl3073x/core.c | 859 ++++++++++ drivers/dpll/zl3073x/core.h | 367 ++++ drivers/dpll/zl3073x/devlink.c | 259 +++ drivers/dpll/zl3073x/devlink.h | 12 + drivers/dpll/zl3073x/dpll.c | 1504 +++++++++++++++++ drivers/dpll/zl3073x/dpll.h | 42 + drivers/dpll/zl3073x/i2c.c | 76 + drivers/dpll/zl3073x/prop.c | 358 ++++ drivers/dpll/zl3073x/prop.h | 34 + drivers/dpll/zl3073x/regs.h | 208 +++ drivers/dpll/zl3073x/spi.c | 76 + include/net/devlink.h | 6 + net/devlink/param.c | 15 + 25 files changed, 4173 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/dpll/dpll-device.yaml create mode 100644 Documentation/devicetree/bindings/dpll/dpll-pin.yaml create mode 100644 Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml create mode 100644 Documentation/networking/devlink/zl3073x.rst create mode 100644 drivers/dpll/zl3073x/Kconfig create mode 100644 drivers/dpll/zl3073x/Makefile create mode 100644 drivers/dpll/zl3073x/core.c create mode 100644 drivers/dpll/zl3073x/core.h create mode 100644 drivers/dpll/zl3073x/devlink.c create mode 100644 drivers/dpll/zl3073x/devlink.h create mode 100644 drivers/dpll/zl3073x/dpll.c create mode 100644 drivers/dpll/zl3073x/dpll.h create mode 100644 drivers/dpll/zl3073x/i2c.c create mode 100644 drivers/dpll/zl3073x/prop.c create mode 100644 drivers/dpll/zl3073x/prop.h create mode 100644 drivers/dpll/zl3073x/regs.h create mode 100644 drivers/dpll/zl3073x/spi.c
Signature · 1 line
2.49.0