Skip to content

Add Microchip ZL3073x support (part 1)

Ivan Vecera linux-devicetree linux-doc lkml netdev 14 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v13 Latest12 patches 8 repliesApplied 12/12
  2. v1214 patches 17 repliesSuperseded
  3. v1114 patches 10 repliesSuperseded
Earlier versions · 11
VersionPostedPatchesRepliesStatus
v1014 patches2 repliesSuperseded
v914 patches4 repliesSuperseded
v88 patches3 repliesSuperseded
v78 patches17 repliesSuperseded
v68 patches6 repliesSuperseded
v58 patches2 repliesSuperseded
v48 patches23 repliesSuperseded
v3 posting 2/28 patches30 repliesSuperseded
v3 posting 1/20 of 10 patches0 repliesSuperseded
v214 patches48 repliesSuperseded
v128 patches41 repliesSuperseded

Changes in v13 from the cover letter

* added support for u64 devlink parameters
* added support for generic devlink parameter 'clock_id'
* several patches squashed into one per @jpirko's advice
* renamed devlink version 'cfg.custom_ver' to 'custom_cfg'
* per discussion with @jpirko, the clock_id is now generated randomly and user have an option to change it via devlink
* implemented devlink reload to apply clock_id change

Patches in v13 All 12 applied

#Subject and filesSizeRepliesApplied
1/12dt-bindings: dpll: Add DPLL device and pinDocumentation/devicetree/bindings/dpll/dpll-device.yaml Documentation/devicetree/bindings/dpll/dpll-pin.yaml MAINTAINERS+123 -00 repliesApplied
2/12dt-bindings: dpll: Add support for Microchip Azurite chip familyDocumentation/devicetree/bindings/dpll/microchip,zl30731.yaml+115 -00 repliesApplied
3/12devlink: Add support for u64 parametersinclude/net/devlink.h net/devlink/param.c+12 -00 repliesApplied
4/12devlink: Add new "clock_id" generic device paramDocumentation/networking/devlink/devlink-params.rst include/net/devlink.h net/devlink/param.c+12 -00 repliesApplied
5/12dpll: Add basic Microchip ZL3073x supportDocumentation/networking/devlink/index.rst Documentation/networking/devlink/zl3073x.rst MAINTAINERS +12 more+1121 -20 repliesApplied
6/12dpll: zl3073x: Fetch invariants during probedrivers/dpll/zl3073x/core.c drivers/dpll/zl3073x/core.h drivers/dpll/zl3073x/regs.h+600 -00 repliesApplied
7/12dpll: zl3073x: Read DPLL types and pin properties from system firmwaredrivers/dpll/zl3073x/Makefile drivers/dpll/zl3073x/core.c drivers/dpll/zl3073x/core.h +2 more+437 -10 repliesApplied
8/12dpll: zl3073x: Register DPLL devices and pinsdrivers/dpll/zl3073x/Makefile drivers/dpll/zl3073x/core.c drivers/dpll/zl3073x/core.h +4 more+1156 -10 repliesApplied
9/12dpll: zl3073x: Implement input pin selection in manual modedrivers/dpll/zl3073x/dpll.c drivers/dpll/zl3073x/prop.c+124 -30 repliesApplied
10/12dpll: zl3073x: Add support to get/set priority on input pinsdrivers/dpll/zl3073x/dpll.c drivers/dpll/zl3073x/prop.c+89 -00 repliesApplied
11/12dpll: zl3073x: Implement input pin state setting in automatic modedrivers/dpll/zl3073x/dpll.c+32 -00 repliesApplied
12/12dpll: zl3073x: Add support to get/set frequency on pinsdrivers/dpll/zl3073x/dpll.c drivers/dpll/zl3073x/regs.h+359 -05 repliesApplied

Reviews trailers per patch

4 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKrzysztof KozlowskiJiri Pirko
SeriesR-b
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v13 thread

Cover letter [PATCH net-next v13 00/12] Add Microchip ZL3073x support (part 1)

Add support for Microchip Azurite DPLL/PTP/SyncE chip family that provides DPLL and PTP functionality. This series bring first part that adds the core functionality and basic DPLL support.

The next part of the series will bring additional DPLL functionality like eSync support, phase offset and frequency offset reporting and phase adjustments.

Testing was done by myself and by Prathosh Satish on Microchip EDS2 development board with ZL30732 DPLL chip connected over I2C bus.

---
Changelog:
v13:
* added support for u64 devlink parameters
* added support for generic devlink parameter 'clock_id'
* several patches squashed into one per @jpirko's advice
* renamed devlink version 'cfg.custom_ver' to 'custom_cfg'
* per discussion with @jpirko, the clock_id is now generated randomly and user have an option to change it via devlink
* implemented devlink reload to apply clock_id change

v12:
* Using 'return dev_err_probe()'
* Separate zl3073x_chip_info structures instead of array
* Use mul_u64_u32_div() to compute input reference frequency to avoid potential overflow
* Removed superfluous check in zl3073x_dpll_output_pin_frequency_set()

v11:
* Fixed uninitialized 'rc' in error-path in patch 9

v10:
* Usage of str_enabled_disabled() where possible.

v9:
After discussion with Jakub Kicinski we agreed that it would be better to implement whole functionality in a single driver without touching MFD sub-system. Besides touching multiple sub-systems by single device there are also some technical issues that are easier resolvable in a single driver. Additionally the firmware flashing functionality would bring more than 1000 lines of code with previous approach to the MFD driver - it is not something the MFD maintainers would like to see.

Ivan Vecera (12):
dt-bindings: dpll: Add DPLL device and pin
dt-bindings: dpll: Add support for Microchip Azurite chip family
devlink: Add support for u64 parameters
devlink: Add new "clock_id" generic device param
dpll: Add basic Microchip ZL3073x support
dpll: zl3073x: Fetch invariants during probe
dpll: zl3073x: Read DPLL types and pin properties from system firmware
dpll: zl3073x: Register DPLL devices and pins
dpll: zl3073x: Implement input pin selection in manual mode
dpll: zl3073x: Add support to get/set priority on input pins
dpll: zl3073x: Implement input pin state setting in automatic mode
dpll: zl3073x: Add support to get/set frequency on pins

 .../devicetree/bindings/dpll/dpll-device.yaml |   76 +
 .../devicetree/bindings/dpll/dpll-pin.yaml    |   45 +
 .../bindings/dpll/microchip,zl30731.yaml      |  115 ++
 .../networking/devlink/devlink-params.rst     |    3 +
 Documentation/networking/devlink/index.rst    |    1 +
 Documentation/networking/devlink/zl3073x.rst  |   51 +
 MAINTAINERS                                   |   10 +
 drivers/Kconfig                               |    4 +-
 drivers/dpll/Kconfig                          |    6 +
 drivers/dpll/Makefile                         |    2 +
 drivers/dpll/zl3073x/Kconfig                  |   36 +
 drivers/dpll/zl3073x/Makefile                 |   10 +
 drivers/dpll/zl3073x/core.c                   |  859 ++++++++++
 drivers/dpll/zl3073x/core.h                   |  367 ++++
 drivers/dpll/zl3073x/devlink.c                |  259 +++
 drivers/dpll/zl3073x/devlink.h                |   12 +
 drivers/dpll/zl3073x/dpll.c                   | 1504 +++++++++++++++++
 drivers/dpll/zl3073x/dpll.h                   |   42 +
 drivers/dpll/zl3073x/i2c.c                    |   76 +
 drivers/dpll/zl3073x/prop.c                   |  358 ++++
 drivers/dpll/zl3073x/prop.h                   |   34 +
 drivers/dpll/zl3073x/regs.h                   |  208 +++
 drivers/dpll/zl3073x/spi.c                    |   76 +
 include/net/devlink.h                         |    6 +
 net/devlink/param.c                           |   15 +
 25 files changed, 4173 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/dpll/dpll-device.yaml
 create mode 100644 Documentation/devicetree/bindings/dpll/dpll-pin.yaml
 create mode 100644 Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml
 create mode 100644 Documentation/networking/devlink/zl3073x.rst
 create mode 100644 drivers/dpll/zl3073x/Kconfig
 create mode 100644 drivers/dpll/zl3073x/Makefile
 create mode 100644 drivers/dpll/zl3073x/core.c
 create mode 100644 drivers/dpll/zl3073x/core.h
 create mode 100644 drivers/dpll/zl3073x/devlink.c
 create mode 100644 drivers/dpll/zl3073x/devlink.h
 create mode 100644 drivers/dpll/zl3073x/dpll.c
 create mode 100644 drivers/dpll/zl3073x/dpll.h
 create mode 100644 drivers/dpll/zl3073x/i2c.c
 create mode 100644 drivers/dpll/zl3073x/prop.c
 create mode 100644 drivers/dpll/zl3073x/prop.h
 create mode 100644 drivers/dpll/zl3073x/regs.h
 create mode 100644 drivers/dpll/zl3073x/spi.c
Signature · 1 line
2.49.0