Skip to content

usb: xhci: enhancements to Interrupt Register Set code

Niklas Neronin linux-usb 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9usb: xhci: set requested IMODI to the closest supported valuedrivers/usb/host/xhci-mem.c drivers/usb/host/xhci.c+6 -61 reply
2/9usb: xhci: improve Interrupt Management register macrosdrivers/usb/host/xhci.c drivers/usb/host/xhci.h+10 -120 replies
3/9usb: xhci: guarantee that IMAN register is flusheddrivers/usb/host/xhci-ring.c drivers/usb/host/xhci.c+6 -00 replies
4/9usb: xhci: remove '0' write to write-1-to-clear registerdrivers/usb/host/xhci.c+7 -60 replies
5/9usb: xhci: rework Event Ring Segment Table Size maskdrivers/usb/host/xhci-mem.c drivers/usb/host/xhci.h+4 -40 replies
6/9usb: xhci: rework Event Ring Segment Table Address maskdrivers/usb/host/xhci-mem.c drivers/usb/host/xhci.h+4 -30 replies
7/9usb: xhci: cleanup IMOD register commentsdrivers/usb/host/xhci.h+18 -150 replies
8/9usb: xhci: rename 'irq_pending' to 'iman'drivers/usb/host/xhci-ring.c drivers/usb/host/xhci.c drivers/usb/host/xhci.h+17 -170 replies
9/9usb: xhci: rename 'irq_control' to 'imod'drivers/usb/host/xhci.c drivers/usb/host/xhci.h+12 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] usb: xhci: enhancements to Interrupt Register Set code

These changes were inspired by reading the xHCI specification and searching for the corresponding code within the xhci driver.

Key improvements include:
* Adjusting the names of Interrupt Register Set values to better match their counterparts in the xHCI specification, facilitating easier cross-referencing.
* Simplify bit masks to ensure they only cover their relevant bits, reducing complexity and potential issues.
* Reword and add comments.

Niklas Neronin (9):
usb: xhci: set requested IMODI to the closest supported value
usb: xhci: improve Interrupt Management register macros
usb: xhci: guarantee that IMAN register is flushed
usb: xhci: remove '0' write to write-1-to-clear register
usb: xhci: rework Event Ring Segment Table Size mask
usb: xhci: rework Event Ring Segment Table Address mask
usb: xhci: cleanup IMOD register comments
usb: xhci: rename 'irq_pending' to 'iman'
usb: xhci: rename 'irq_control' to 'imod'

 drivers/usb/host/xhci-mem.c  | 13 +++----
 drivers/usb/host/xhci-ring.c | 11 +++---
 drivers/usb/host/xhci.c      | 43 +++++++++++++---------
 drivers/usb/host/xhci.h      | 70 ++++++++++++++++++------------------
 4 files changed, 73 insertions(+), 64 deletions(-)
Signature · 1 line
2.47.2