Skip to content

serial: 8250_of: support an optional bus clock

Alex Elder linux-devicetree linux-serial lkml spacemit 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 2 repliesIn review
  2. v33 patches 6 repliesSuperseded
  3. v22 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches5 repliesSuperseded

Changes in v4 from the cover letter

- I simplified the third patch by reusing the local variable, as suggested by Andy Shevchenko
- The first two patches are identical to what was in v3

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: serial: 8250: support an optional second clockDocumentation/devicetree/bindings/serial/8250.yaml+29 -10 replies
2/3serial: 8250_of: add support for an optional bus clockdrivers/tty/serial/8250/8250_of.c+10 -10 replies
3/3serial: 8250_of: manage bus clock in suspend/resumedrivers/tty/serial/8250/8250_of.c+4 -02 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchRob Herring (Arm)Yixun LanAndy Shevchenko
1/3R-b
2/3
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/3] serial: 8250_of: support an optional bus clock

The SpacemiT UART hardware requires a bus clock to be enabled in addition to the primary function clock.

This series makes it possible to specify both clocks via DTS. If a bus clock is required, it and the primary clock are fetched by name.

This code is available here:
https://github.com/riscstar/linux/tree/outgoing/serial-v4

Changes between v3 and v4:
- I simplified the third patch by reusing the local variable, as suggested by Andy Shevchenko
- The first two patches are identical to what was in v3

Here is version 3 of this series:
https://lore.kernel.org/lkml/[email protected]/

Changes between v2 and v3:
- A third patch was added to disable the bus clock on suspend and enable it again on resume, as requested by Yixun Lan
- Rob's Reviewed-by tag has been added to patch 1
- The first two patches are otherwise identical to what was in v2

Here is version 2 of this series:
https://lore.kernel.org/lkml/[email protected]/

Changes between v1 and v2:
- The DT binding was fixed to properly define the number of clocks and clock names based on the compatible string, as suggested by Rob Herring
- Logic to look up the optional bus clock was changed as requested by Andy Shevchenko
- The bus clock pointer (which was never used after it was enabled) was renmoved from the of_serial_info structure

Here is the first version of this series:
https://lore.kernel.org/lkml/[email protected]/

-Alex

Alex Elder (3):
dt-bindings: serial: 8250: support an optional second clock
serial: 8250_of: add support for an optional bus clock
serial: 8250_of: manage bus clock in suspend/resume

 .../devicetree/bindings/serial/8250.yaml      | 30 ++++++++++++++++++-
 drivers/tty/serial/8250/8250_of.c             | 15 +++++++++-
 2 files changed, 43 insertions(+), 2 deletions(-)

base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8

Signature · 1 line
2.45.2