Skip to content

net: pktgen: fix checkpatch code style errors/warnings

Peter Seiderer lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesApplied 3/3
  2. v111 patches 5 repliesSuperseded 6 of 11 applied

Changes in v2 from the cover letter

- drop already applied patches
- update "net: pktgen: fix code style (ERROR: else should follow close brace '}')"
Additional add braces around the else statement (as suggested by a follow up checkpatch run and by Jakub Kicinski from code review).
- update "net: pktgen: fix code style (WARNING: please, no space before tabs)" Change from spaces to tab for indent (suggested by Jakub Kicinski).
- update "net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)" Squash memset/strscpy pattern into single strscpy_pad call (suggested by Jakub Kicinski).
- drop "net: pktgen: fix code style (WARNING: braces {} are not necessary for single statement blocks)" (suggestd by Jakub Kicinski)

Patches in v2 All 3 applied

#Subject and filesSizeRepliesApplied
1/3net: pktgen: fix code style (ERROR: else should follow close brace '}')net/core/pktgen.c+2 -21 replyApplied
2/3net: pktgen: fix code style (WARNING: please, no space before tabs)net/core/pktgen.c+1 -11 replyApplied
3/3net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)net/core/pktgen.c+7 -111 replyApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSimon Horman
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/3] net: pktgen: fix checkpatch code style errors/warnings

Fix checkpatch detected code style errors/warnings detected in the file net/core/pktgen.c (remaining checkpatch checks will be addressed in a follow up patch set).

Changes v1 -> v2:
- drop already applied patches
- update "net: pktgen: fix code style (ERROR: else should follow close brace '}')"
Additional add braces around the else statement (as suggested by a follow up checkpatch run and by Jakub Kicinski from code review).
- update "net: pktgen: fix code style (WARNING: please, no space before tabs)" Change from spaces to tab for indent (suggested by Jakub Kicinski).
- update "net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)" Squash memset/strscpy pattern into single strscpy_pad call (suggested by Jakub Kicinski).
- drop "net: pktgen: fix code style (WARNING: braces {} are not necessary for single statement blocks)" (suggestd by Jakub Kicinski)

Peter Seiderer (3):
net: pktgen: fix code style (ERROR: else should follow close brace

    '}')

net: pktgen: fix code style (WARNING: please, no space before tabs)
net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)

 net/core/pktgen.c | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)
Signature · 1 line
2.49.0