Skip to content

mmc: omap_hsmmc: Restore the init_stream sequence

Mathieu Othacehe u-boot 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2mmc: Add a new callback function to perform the 74 clocks cycle sequencedrivers/mmc/mmc-uclass.c drivers/mmc/mmc.c include/mmc.h+28 -00 replies
2/2mmc: omap_hsmmc: implement send_init_stream callbackdrivers/mmc/omap_hsmmc.c+11 -20 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchPeng Fan
SeriesReviewd-by
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] mmc: omap_hsmmc: Restore the init_stream sequence

Hello,

Back in 2019, the init_stream sequence was disabled with db52e19ced because:

This is not required. The MMC core sends CMD0 right after the initialization and it serves the same purpose.

That is wrong. It does not serve the same purpose at all. The init_stream function role is to keep the CMD line high for 74 clock cycles which is required by the SD specification[1]:

A device shall be ready to accept the first command within 1ms from detecting VDD min. Device may use up to 74 clocks for preparation before receiving the first command.

It turns out that one of the devices I am speaking to is requiring those 74 clocks sequence before the send of the CMD0 as described in the specification.

It was then broken since 2019.

I guess that most of the other devices out there are able to cope with those 74 clocks sequence missing and can respond directly to CMD0, which is why that went unnoticed with the omap_hsmmc driver users.

I am proposing to restore that sequence, which is also used on the Linux side.

Thanks,

Mathieu

[1]: https://academy.cba.mit.edu/classes/networking_communications/SD/SD.pdf

Jean-Jacques Hiblot (1):
mmc: Add a new callback function to perform the 74 clocks cycle
sequence

Mathieu Othacehe (1):
mmc: omap_hsmmc: implement send_init_stream callback

 drivers/mmc/mmc-uclass.c | 13 +++++++++++++
 drivers/mmc/mmc.c        |  6 ++++++
 drivers/mmc/omap_hsmmc.c | 13 +++++++++++--
 include/mmc.h            |  9 +++++++++
 4 files changed, 39 insertions(+), 2 deletions(-)
Signature · 1 line
2.47.1