Skip to content

xen/rangeset: one bugfix and unit testing

Roger Pau Monne xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xen/rangeset: fix incorrect subtractionxen/common/rangeset.c+2 -11 reply
2/2tootls/tests: introduce unit tests for rangesetstools/tests/Makefile tools/tests/rangeset/Makefile tools/tests/rangeset/harness.h +1 more+345 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJan Beulich
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] xen/rangeset: one bugfix and unit testing

Hello,

Rangesets are extensively used inside of Xen, yet we had no unit tests to ensure it's correctness. rangeset_remove_range() is in fact bogus and will generate an incorrect output rangeset depending on the inputs.

Patch 1 fixes the bug, patch 2 adds some basic unit testing to ensure the fix done by patch 1 is correct. The unit testing should likely be expanded (in a different series) to further assert the correctness of other rangeset operations.

Thanks, Roger.

Roger Pau Monne (2):
xen/rangeset: fix incorrect subtraction tootls/tests: introduce unit tests for rangesets

 tools/tests/Makefile                 |   1 +
 tools/tests/rangeset/Makefile        |  45 ++++++
 tools/tests/rangeset/harness.h       |  71 +++++++++
 tools/tests/rangeset/test-rangeset.c | 228 +++++++++++++++++++++++++++
 xen/common/rangeset.c                |   3 +-
 5 files changed, 347 insertions(+), 1 deletion(-)
 create mode 100644 tools/tests/rangeset/Makefile
 create mode 100644 tools/tests/rangeset/harness.h
 create mode 100644 tools/tests/rangeset/test-rangeset.c
Signature · 1 line
2.48.1