Skip to content

DIAG 308: extend subcode 10 to return UVC cmd id, RC and RRC values upon failure to enter secure mode

Gautam Gala qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 1 replyIn review
  2. v43 patches 5 repliesSuperseded
  3. v33 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches5 repliesSuperseded
v13 patches3 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3target/s390x: Introduce constant when checking if PV header couldn't be decryptedtarget/s390x/kvm/pv.c+2 -10 replies
2/3target/s390x: Introduce function when exiting PVtarget/s390x/kvm/pv.c+6 -80 replies
3/3target/s390x: Return UVC cmd code, RC and RRC value when DIAG 308 Subcode 10 fails to enter secure modehw/s390x/ipl.c hw/s390x/ipl.h hw/s390x/s390-virtio-ccw.c +2 more+73 -351 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSteffen EidenJanosch Frank
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] DIAG 308: extend subcode 10 to return UVC cmd id, RC and RRC values upon failure to enter secure mode

DIAG 308 (subcode 10 - performing secure execution unpack) response code when the configuration is unable to enter secure mode has limited usability as it is a fixed value (0xa02) for variety of different reasons. The aim is to extend this DIAG to return UVC command ID, RC and RRC values in addition to the diag response code. This feature can be used by the stage3a bootloader (s390-tools/rust/pvimg/boot) to read these new values from the corresponding register and print an appropriate error message to help pin point the cause.

The response code, UVC RC, RRC, and command ID are returned in bit positions 48-63, 32-47, 16-31, and 0-15 of register R1 + 1 if the function does not complete successfully (Previously, only the response code was returned in bits 48-63).

These patches contains updates based on feedback from Janosch Frank and Thomas Huth from message-IDs <[email protected]> and <[email protected]>

Gautam Gala (3):
target/s390x: Introduce constant when checking if PV header couldn't
be decrypted
target/s390x: Introduce function when exiting PV target/s390x: Return UVC cmd code, RC and RRC value when DIAG 308
Subcode 10 fails to enter secure mode

 hw/s390x/ipl.c             | 11 ++++---
 hw/s390x/ipl.h             |  6 ++--
 hw/s390x/s390-virtio-ccw.c | 14 ++++----
 target/s390x/kvm/pv.c      | 66 +++++++++++++++++++++++++-------------
 target/s390x/kvm/pv.h      | 26 +++++++++++----
 5 files changed, 80 insertions(+), 43 deletions(-)
Signature · 1 line
2.49.0