Skip to content

xen/x86: fix implementation of subpage r/o MMIO

Roger Pau Monne xen-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 5 repliesIn review
  2. v34 patches 7 repliesSuperseded
  3. v24 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches20 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4xen/io: provide helpers for multi size MMIO accessesxen/arch/x86/hvm/vmsi.c xen/arch/x86/mm.c xen/drivers/vpci/msix.c +1 more+85 -1113 replies
2/4x86/hvm: fix handling of accesses to partial r/o MMIO pagesxen/arch/x86/hvm/Makefile xen/arch/x86/hvm/emulate.c xen/arch/x86/hvm/hvm.c +5 more+160 -902 replies
3/4x86/hvm: only register the r/o subpage ops when neededxen/arch/x86/hvm/hvm.c xen/arch/x86/include/asm/mm.h xen/arch/x86/mm.c+19 -10 replies
4/4x86/mm: move mmio_ro_emulated_write() to PV only filexen/arch/x86/include/asm/mm.h xen/arch/x86/mm.c xen/arch/x86/pv/ro-page-fault.c+41 -450 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJan Beulich
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] xen/x86: fix implementation of subpage r/o MMIO

Hello,

Following series include some bugfixes and improvements to the handling of subpage r/o MMIO accesses.

Patch 1 introduces a helper to reduce code duplication when performing MMIO accesses.

Patch 2 is a bugfix for using subpage in HVM guest, and patch 3 is an optimization to only register the HVM subpage handler when needed.

Finally patch 4 moves some PV only code to a PV specific file.

Thanks, Roger.

Roger Pau Monne (4):
xen/io: provide helpers for multi size MMIO accesses x86/hvm: fix handling of accesses to partial r/o MMIO pages x86/hvm: only register the r/o subpage ops when needed x86/mm: move mmio_ro_emulated_write() to PV only file

 xen/arch/x86/hvm/Makefile              |   1 +
 xen/arch/x86/hvm/emulate.c             |  54 ++---------
 xen/arch/x86/hvm/hvm.c                 |  18 ++--
 xen/arch/x86/hvm/mmio.c                | 125 +++++++++++++++++++++++++
 xen/arch/x86/hvm/vmsi.c                |  47 +---------
 xen/arch/x86/include/asm/hvm/emulate.h |   1 -
 xen/arch/x86/include/asm/hvm/io.h      |   3 +
 xen/arch/x86/include/asm/mm.h          |  21 +++--
 xen/arch/x86/mm.c                      | 106 +++++----------------
 xen/arch/x86/pv/ro-page-fault.c        |  41 ++++++++
 xen/drivers/vpci/msix.c                |  47 +---------
 xen/include/xen/io.h                   |  70 ++++++++++++++
 12 files changed, 296 insertions(+), 238 deletions(-)
 create mode 100644 xen/arch/x86/hvm/mmio.c
 create mode 100644 xen/include/xen/io.h
Signature · 1 line
2.48.1