Skip to content

trace-cmd record: Fix compression on big-endian systems

Ilya Leoshkevich linux-trace-devel 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v11 patch 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2trace-cmd record: Fix compression on big-endian systemslib/trace-cmd/trace-compress.c+20 -50 replies
2/2libtracecmd: Add missing error handling to trace-compress.clib/trace-cmd/trace-compress.c+6 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] trace-cmd record: Fix compression on big-endian systems

v1: https://lore.kernel.org/linux-trace-devel/[email protected]/
v1 -> v2: Factor out read_size_val(), split out the error handling
change (Steven).

Hi,

While running trace-cmd on s390x, I ran into a few issues. This is the fix for the first one: trace-cmd report prints nothing.

The second one is a kernel issue [1], which causes trace-cmd to print a lot of bogus space characters.

The final one is "error in size of file '/proc/kallsyms'" caused by delayed removal of a BPF program from /proc/kallsyms. I plan to fix it by reading the contents of /proc/kallsyms into a temporary file before writing it into the trace file.

[1] https://lore.kernel.org/lkml/[email protected]/

Best regards,
Ilya

Ilya Leoshkevich (2):
trace-cmd record: Fix compression on big-endian systems
libtracecmd: Add missing error handling to trace-compress.c

 lib/trace-cmd/trace-compress.c | 32 +++++++++++++++++++++++++-------
 1 file changed, 25 insertions(+), 7 deletions(-)
Signature · 1 line
2.49.0