Skip to content

net: ch9200: fix various bugs and improve qinheng ch9200 driver

Qasim Ijaz linux-usb lkml netdev oe-kbuild-all stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: ch9200: fix uninitialised access bug during mii_nway_restartdrivers/net/usb/ch9200.c+5 -21 reply
2/5net: ch9200: remove extraneous return that prevents error propagationdrivers/net/usb/ch9200.c+0 -20 replies
3/5net: ch9200: fail fast on control_read() failures during get_mac_address()drivers/net/usb/ch9200.c+19 -130 replies
4/5net: ch9200: add missing error handling in ch9200_bind()drivers/net/usb/ch9200.c+15 -32 replies
5/5net: ch9200: avoid triggering NWay restart on non-zero PHY IDdrivers/net/usb/ch9200.c+1 -111 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchsyzbotSimon HormanAndrew Lunn
1/5T-b R-b
2/5R-b
3/5R-b
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/5] net: ch9200: fix various bugs and improve qinheng ch9200 driver

This patch series aims to fix various issues throughout the QinHeng CH9200 driver. This driver fails to handle various failures, which in one case has lead to a uninit access bug found via syzbot. Upon reviewing the driver I fixed a few more issues which I have included in this patch series.

Parts of this series are the product of discussions and suggestions I had from others like Andrew Lunn, Simon Horman and Jakub Kicinski you can view those discussions below:

Qasim Ijaz (5):
fix uninitialised access bug during mii_nway_restart remove extraneous return that prevents error propagation fail fast on control_read() failures during get_mac_address() add missing error handling in ch9200_bind()
avoid triggering NWay restart on non-zero PHY ID

 drivers/net/usb/ch9200.c | 61 ++++++++++++++++++++++++++--------------
 1 file changed, 40 insertions(+), 21 deletions(-)
Signature · 1 line
2.39.5