mm/vmalloc.c: code cleanup and improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 2 repliesIn review 4 of 5 applied
- v15 patches 26 repliesSuperseded
Changes in v2 from the cover letter
=======
- In patch 3:
- made change to improve code according to Uladzislau's suggestion;
- use WRITE_ONCE() to assign the value to vn->pool[i].len finally, according to Shivank's suggestion.
In patch 5:
- add back the WARN_ON_ONCE() on returned value from va_clip() invocation, and also add back the code comment. These are pointed out by Uladzislau.
- Add reviewers' tag from Uladzislau, Shivank and Vishal. And I only add Shivank's tag in patch 1, 2, 4 according to his comment because patch 3 and 5 are changed in v2.
Patches in v2 4 of 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | mm/vmalloc.c: change purge_ndoes as local static variablemm/ | +1 | 0 replies | |
| 2/5 | mm/vmalloc.c: find the vmap of vmap_nodes in reverse ordermm/ | +2 | 0 replies | Applied |
| 3/5 | mm/vmalloc.c: optimize code in decay_va_pool_node() a little bitmm/ | +11 | 0 replies | Applied |
| 4/5 | mm/vmalloc: optimize function vm_unmap_aliases()mm/ | +1 | 0 replies | Applied |
| 5/5 | mm/vmalloc.c: return explicit error value in alloc_vmap_area()mm/ | +13 | 1 reply | Applied |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Uladzislau Rezki (Sony) | Vishal Moola (Oracle) | Shivank Garg |
|---|---|---|---|
| Series | R-b | ||
| 1/5 | R-b | R-b | R-b |
| 2/5 | R-b | R-b | |
| 3/5 | |||
| 4/5 | R-b | R-b | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/5] mm/vmalloc.c: code cleanup and improvements
These were made from code inspection in mm/vmalloc.c.
v1->v2:
=======
- In patch 3:
- made change to improve code according to Uladzislau's suggestion;
- use WRITE_ONCE() to assign the value to vn->pool[i].len finally, according to Shivank's suggestion.
In patch 5:
- add back the WARN_ON_ONCE() on returned value from va_clip() invocation, and also add back the code comment. These are pointed out by Uladzislau.
- Add reviewers' tag from Uladzislau, Shivank and Vishal. And I only add Shivank's tag in patch 1, 2, 4 according to his comment because patch 3 and 5 are changed in v2.
Baoquan He (5):
mm/vmalloc.c: change purge_ndoes as local static variable mm/vmalloc.c: find the vmap of vmap_nodes in reverse order mm/vmalloc.c: optimize code in decay_va_pool_node() a little bit mm/vmalloc: optimize function vm_unmap_aliases() mm/vmalloc.c: return explicit error value in alloc_vmap_area()
mm/vmalloc.c | 61 ++++++++++++++++++++++++---------------------------- 1 file changed, 28 insertions(+), 33 deletions(-)
Signature · 1 line
2.41.0