Skip to content

mm/vmalloc.c: code cleanup and improvements

Baoquan He linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 2 repliesIn review 4 of 5 applied
  2. v15 patches 26 repliesSuperseded

Changes in v2 from the cover letter

=======
- In patch 3:
- made change to improve code according to Uladzislau's suggestion;
- use WRITE_ONCE() to assign the value to vn->pool[i].len finally, according to Shivank's suggestion.
In patch 5:
- add back the WARN_ON_ONCE() on returned value from va_clip() invocation, and also add back the code comment. These are pointed out by Uladzislau.

- Add reviewers' tag from Uladzislau, Shivank and Vishal. And I only add Shivank's tag in patch 1, 2, 4 according to his comment because patch 3 and 5 are changed in v2.

Patches in v2 4 of 5 applied

#Subject and filesSizeRepliesApplied
1/5mm/vmalloc.c: change purge_ndoes as local static variablemm/vmalloc.c+1 -10 replies
2/5mm/vmalloc.c: find the vmap of vmap_nodes in reverse ordermm/vmalloc.c+2 -20 repliesApplied
3/5mm/vmalloc.c: optimize code in decay_va_pool_node() a little bitmm/vmalloc.c+11 -120 repliesApplied
4/5mm/vmalloc: optimize function vm_unmap_aliases()mm/vmalloc.c+1 -40 repliesApplied
5/5mm/vmalloc.c: return explicit error value in alloc_vmap_area()mm/vmalloc.c+13 -141 replyApplied

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchUladzislau Rezki (Sony)Vishal Moola (Oracle)Shivank Garg
SeriesR-b
1/5R-b R-b R-b
2/5R-b R-b
3/5
4/5R-b R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/5] mm/vmalloc.c: code cleanup and improvements

These were made from code inspection in mm/vmalloc.c.

v1->v2:
=======
- In patch 3:
- made change to improve code according to Uladzislau's suggestion;
- use WRITE_ONCE() to assign the value to vn->pool[i].len finally, according to Shivank's suggestion.
In patch 5:
- add back the WARN_ON_ONCE() on returned value from va_clip() invocation, and also add back the code comment. These are pointed out by Uladzislau.

- Add reviewers' tag from Uladzislau, Shivank and Vishal. And I only add Shivank's tag in patch 1, 2, 4 according to his comment because patch 3 and 5 are changed in v2.

Baoquan He (5):
mm/vmalloc.c: change purge_ndoes as local static variable mm/vmalloc.c: find the vmap of vmap_nodes in reverse order mm/vmalloc.c: optimize code in decay_va_pool_node() a little bit mm/vmalloc: optimize function vm_unmap_aliases() mm/vmalloc.c: return explicit error value in alloc_vmap_area()

 mm/vmalloc.c | 61 ++++++++++++++++++++++++----------------------------
 1 file changed, 28 insertions(+), 33 deletions(-)
Signature · 1 line
2.41.0