Skip to content

ASoC: codecs: wcd938x: fix mux error handling

Johan Hovold linux-sound lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: codecs: wcd938x: fix mux error handlingsound/soc/codecs/wcd938x.c+11 -113 replies
2/2ASoC: codecs: wcd938x: drop unnecessary mux flag assignmentsound/soc/codecs/wcd938x.c+0 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ASoC: codecs: wcd938x: fix mux error handling

A recent change added support for looking up an optional mux control before falling back to gpio control for us-euro plug selection.

The mux framework does however not yet support optional muxes and an error message is now incorrectly logged on machines like the Lenovo ThinkPad X13s which do not have one:

wcd938x_codec audio-codec: /audio-codec: failed to get mux-control (0)

Suppress the bogus error and add the missing mux error handling by making sure that the 'mux-controls' DT property is present before looking up the mux control.

Included is also a related cleanup.

Johan

Johan Hovold (2):
ASoC: codecs: wcd938x: fix mux error handling
ASoC: codecs: wcd938x: drop unnecessary mux flag assignment

 sound/soc/codecs/wcd938x.c | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)
Signature · 1 line
2.49.0