Skip to content

libtracecmd: Support changing /proc/kallsyms

Ilya Leoshkevich linux-trace-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 1 replySuperseded
  3. v11 patch 5 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2libtracecmd: Support querying position within a new compressed blocklib/trace-cmd/trace-compress.c+4 -10 replies
2/2libtracecmd: Support changing /proc/kallsymslib/trace-cmd/trace-output.c+37 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] libtracecmd: Support changing /proc/kallsyms

v2: https://lore.kernel.org/linux-trace-devel/[email protected]/
v2 -> v3: Add a comment and some newlines (Steven).

v1: https://lore.kernel.org/linux-trace-devel/[email protected]/
v1 -> v2: Rewrite the size instead of reading the file twice (Steven).
Turns out exposing do_lseek() is not necessary, since everything is in the same C file.

Hi,

this series fixes tracing in presence of frequent BPF or kernel module loads/unloads. Patch 1 is a small required improvement; patch 2 is the actual implementation.

The problem can be reproduced like this:

    # while true; do rmmod loop; modprobe loop; done &
    # while trace-cmd record -p function_graph /bin/true; do :; done
      plugin 'function_graph'
    libtracecmd: Invalid argument
      error in size of file '/proc/kallsyms'
    trace-cmd: Invalid argument
      Error creating output file

Best regards,
Ilya

Ilya Leoshkevich (2):
libtracecmd: Support querying position within a new compressed block
libtracecmd: Support changing /proc/kallsyms

 lib/trace-cmd/trace-compress.c |  5 ++++-
 lib/trace-cmd/trace-output.c   | 38 +++++++++++++++++++++++++++++++++-
 2 files changed, 41 insertions(+), 2 deletions(-)
Signature · 1 line
2.50.1