drm/gpusvm, drm/pagemap, drm/xe: Restructure migration in preparation for multi-device
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 0 repliesNew
- v53 patches 3 repliesSuperseded
- v43 patches 4 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 10 replies | Superseded | |
| v2 | 3 patches | 10 replies | Superseded | |
| v1 | 3 patches | 0 replies | Superseded |
Changes in v6 from the cover letter
- Fix an uninitialized variable (CI)
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | drm/gpusvm, drm/pagemap: Move migration functionality to drm_pagemapDocumentation/ drivers/ drivers/ +7 more | +958 | 0 replies | |
| 2/3 | drm/pagemap: Add a populate_mm opdrivers/ drivers/ include/ | +92 | 0 replies | |
| 3/3 | drm/xe: Implement and use the drm_pagemap populate_mm opdrivers/ drivers/ drivers/ +2 more | +77 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Himal Prasad Ghimiray | Matthew Brost |
|---|---|---|
| 1/3 | R-b | |
| 2/3 | R-b | |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/3] drm/gpusvm, drm/pagemap, drm/xe: Restructure migration in preparation for multi-device
This patchset modifies the migration part of drm_gpusvm to drm_pagemap and adds a populate_mm() op to drm_pagemap.
The idea is that the device that receives a pagefault determines if it wants to migrate content and to where. It then calls the populate_mm() method of relevant drm_pagemap.
This functionality was mostly already in place, but hard-coded for xe only without going through a pagemap op. Since we might be dealing with separate devices moving forward, it also now becomes the responsibilit of the populate_mm() op to grab any necessary local device runtime pm references and keep them held while its pages are present in an mm (struct mm_struct).
On thing to decide here is whether the populate_mm() callback should sit on a struct drm_pagemap for now while we sort multi-device usability out or whether we should add it (or something equivalent) to struct dev_pagemap.
v2:
- Rebase.
v3:
- Documentation updates (CI, Matt Brost)
- Don't change TTM buffer object type for VRAM allocations (Matt Brost) v4:
- Documentation Updates (Himal Ghimiray, Matt Brost)
- Add an assert (Matt Brost)
v5:
- Rebase
- Add R-Bs and SOBs.
v6:
- Fix an uninitialized variable (CI)
Matthew Brost (1):
drm/gpusvm, drm/pagemap: Move migration functionality to drm_pagemap
Thomas Hellström (2):
drm/pagemap: Add a populate_mm op
drm/xe: Implement and use the drm_pagemap populate_mm op
Documentation/gpu/rfc/gpusvm.rst | 12 +- drivers/gpu/drm/Makefile | 6 +- drivers/gpu/drm/drm_gpusvm.c | 762 +----------------------- drivers/gpu/drm/drm_pagemap.c | 838 +++++++++++++++++++++++++++ drivers/gpu/drm/xe/Kconfig | 10 +- drivers/gpu/drm/xe/xe_bo_types.h | 2 +- drivers/gpu/drm/xe/xe_device_types.h | 2 +- drivers/gpu/drm/xe/xe_svm.c | 125 ++-- drivers/gpu/drm/xe/xe_svm.h | 10 +- drivers/gpu/drm/xe/xe_tile.h | 11 + drivers/gpu/drm/xe/xe_vm.c | 2 +- include/drm/drm_gpusvm.h | 96 --- include/drm/drm_pagemap.h | 135 +++++ 13 files changed, 1099 insertions(+), 912 deletions(-) create mode 100644 drivers/gpu/drm/drm_pagemap.c
Signature · 1 line
2.49.0