Support dates outside of 1901..2038 range
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest2 patches 1 replyIn review
- v52 patches 4 repliesSuperseded
- v42 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 2 patches | 7 replies | Superseded |
Changes in v6 from the cover letter
datetime.c:
Move comment line "There are three 100-year periods worth of leap
days (3*24)" down one line.
Change order of terms in 'days' calculation to be more readable.date_unit_test.c:
Correct comment to "Leap year, after Feb" instead of "prior to Feb"
Add "reviewed by" from Daniel Kiper for patches with permission.
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | datetime: Support dates outside of 1901..2038 rangegrub-core/ include/ | +73 | 0 replies | |
| 2/2 | date_unit_test: test dates outside of 32-bit unix rangetests/ | +66 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Kiper |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/2] Support dates outside of 1901..2038 range
Support dates outside of 1901..2038.
Add tests for dates outside this range.
Vast majority of the work was done by Vladimir Serbinenko
V5 -> V6:datetime.c:
Move comment line "There are three 100-year periods worth of leap
days (3*24)" down one line.
Change order of terms in 'days' calculation to be more readable.date_unit_test.c:
Correct comment to "Leap year, after Feb" instead of "prior to Feb"
Add "reviewed by" from Daniel Kiper for patches with permission.
V4 -> V5:datetime.c / h:
Rename variables "is_bisextile" to "bisextile".
Change some boolean assignments to use ternary operator. Compare booleans to true instead of checking "if(boolean)".date_unit_test.c:
Add additional commentary to the tests array for meaning of numbers. Rework test ranges to cover from years 0001 to 9999 and add specific min/max tests for min 0001 date and max 9999 date.
V3 -> V4: Add additional commentary for a few magic numbers
and fix some coding standard issues.
V2 -> V3: Added additional commentary to datetime.c to describe
the origin of some of the numbers used in calculations.
Andrew Hamilton (2):
datetime: Support dates outside of 1901..2038 range
date_unit_test: test dates outside of 32-bit unix range
grub-core/lib/datetime.c | 65 +++++++++++++++++++++++++++------- include/grub/datetime.h | 28 ++++++++++----- tests/date_unit_test.c | 75 +++++++++++++++++++++++++++++++++++----- 3 files changed, 139 insertions(+), 29 deletions(-)
Signature · 7 lines
2.39.5 _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel