Skip to content

staging: gpib: Fixes and cleanup for gpio driver

Dave Penkler linux-staging lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8staging: gpib: Fix request_system_control in gpiodrivers/staging/gpib/gpio/gpib_bitbang.c+7 -30 replies
2/8staging: gpib: Fix setting controller-in-chargedrivers/staging/gpib/gpio/gpib_bitbang.c+1 -10 replies
3/8staging: gpib: Enable SRQ irq on request_system_controldrivers/staging/gpib/gpio/gpib_bitbang.c+4 -20 replies
4/8staging: gpib: Remove dependency on LED subsystemdrivers/staging/gpib/gpio/gpib_bitbang.c+6 -170 replies
5/8staging: gpib: Remove atn_asserted global variabledrivers/staging/gpib/gpio/gpib_bitbang.c+8 -80 replies
6/8staging: gpib: Change error code for no listenerdrivers/staging/gpib/gpio/gpib_bitbang.c+1 -10 replies
7/8staging: gpib: Cleanup allocate_gpios codedrivers/staging/gpib/gpio/gpib_bitbang.c+18 -210 replies
8/8staging: gpib: Set control lines in attachdrivers/staging/gpib/gpio/gpib_bitbang.c+4 -00 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchDave Penkler
1/8T-b
2/8T-b
3/8T-b
4/8T-b
5/8T-b
6/8T-b
7/8T-b
8/8T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] staging: gpib: Fixes and cleanup for gpio driver

This set of patches addresses a number of fixes and cleanups for the gpio bitbang driver.

Patch 1 Fixes the faulty implementation of the request_system_control
function.
Patch 2 Moves the code for setting the controller-in-charge to the
correct function as per the standard.
Patch 3 Defers enabling the SRQ irq to when becoming system controller. Patch 4 Removes need for cumbersome setup for the activity led with
the yoga board.
Patch 5 Removes a no longer needed workaround for missed irqs. Patch 6 Corrects the error return for no listeners so that the user
library reports the appropriate user error code.
Patch 7 Improves the code for the allocate_gpios function Patch 8 Fixes potential hangs due to undefined control line state
on initialization.

Dave Penkler (8):
staging: gpib: Fix request_system_control in gpio
staging: gpib: Fix setting controller-in-charge
staging: gpib: Enable SRQ irq on request_system_control
staging: gpib: Remove dependency on LED subsystem
staging: gpib: Remove atn_asserted global variable
staging: gpib: Change error code for no listener
staging: gpib: Cleanup allocate_gpios code
staging: gpib: Set control lines in attach

 drivers/staging/gpib/gpio/gpib_bitbang.c | 102 +++++++++++------------
 1 file changed, 49 insertions(+), 53 deletions(-)
Signature · 1 line
2.49.0