gve: Add Rx HW timestamping support
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest8 patches 0 repliesApplied 8/8
- v48 patches 6 repliesSuperseded
- v38 patches 4 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 8 patches | 6 replies | Superseded | |
| v1 | 6 patches | 12 replies | Superseded |
Changes in v5 from the cover letter
- Change to register PTP when initializing the driver and keep it alive until destroying the driver. (Jakub Kicinski)
- Utilize ptp_cancel_worker_sync instead of unregistering the PHC every time when rx timestamping is disabled. (Jakub Kicinski)
- Add gve_clock_nic_ts_read before the ptp_schedule_worker to do the first refresh. (Jakub Kicinski)
- Add the phc_index info into the gve_get_ts_info. (Jakub Kicinski)
Patches in v5 All 8 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | gve: Add device option for nic clock synchronizationdrivers/ drivers/ drivers/ | +42 | 0 replies | Applied |
| 2/8 | gve: Add adminq command to report nic timestampdrivers/ drivers/ drivers/ +1 more | +42 | 0 replies | Applied |
| 3/8 | gve: Add initial PTP device supportdrivers/ drivers/ drivers/ +1 more | +71 | 0 replies | Applied |
| 4/8 | gve: Add adminq lock for queues creation and destructiondrivers/ | +36 | 0 replies | Applied |
| 5/8 | gve: Add support to query the nic clockdrivers/ drivers/ drivers/ | +109 | 0 replies | Applied |
| 6/8 | gve: Add rx hardware timestamp expansiondrivers/ | +23 | 0 replies | Applied |
| 7/8 | gve: Implement ndo_hwtstamp_get/set for RX timestampingdrivers/ drivers/ drivers/ +1 more | +54 | 0 replies | Applied |
| 8/8 | gve: Advertise support for rx hardware timestampingdrivers/ | +22 | 0 replies | Applied |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Willem de Bruijn |
|---|---|
| 1/8 | R-b |
| 2/8 | R-b |
| 3/8 | R-b |
| 4/8 | R-b |
| 5/8 | R-b |
| 6/8 | R-b |
| 7/8 | R-b |
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v5 0/8] gve: Add Rx HW timestamping support
From: Ziwei Xiao <[email protected]>
This patch series add the support of Rx HW timestamping, which sends adminq commands periodically to the device for clock synchronization with the NIC.
The ability to read the PHC from user space will be added in the future patch series when adding the actual PTP support. For this patch series, it's adding the initial ptp to utilize the ptp_schedule_worker to schedule the work of syncing the NIC clock.
Changes:
v5:
- Change to register PTP when initializing the driver and keep it alive until destroying the driver. (Jakub Kicinski)
- Utilize ptp_cancel_worker_sync instead of unregistering the PHC every time when rx timestamping is disabled. (Jakub Kicinski)
- Add gve_clock_nic_ts_read before the ptp_schedule_worker to do the first refresh. (Jakub Kicinski)
- Add the phc_index info into the gve_get_ts_info. (Jakub Kicinski)
v4:
- release the ptp in the error path of gve_init_clock (Jakub Kicinski)
- add two more reserved fields in gve_nic_ts_report, anticipating upcoming use, to align size expectations with the device from the start (team internal review, Shachar Raindel)
v3:
- change the last_read to be u64 on patch 6/8 (Vadim Fedorenko)
- update the title and commit message of patch 7/8 to show it's adding support for ndo functions instead of ioctls (Jakub Kicinski)
- Utilize extack for error logging instead of dev_err (Jakub Kicinski)
v2:
- add initial PTP device support to utilize the ptp's aux_work to schedule sending adminq commands periodically (Jakub Kicinski, Vadim Fedorenko)
- add adminq lock patch into this patch series instead of sending out to net since it's only needed to resolve the conflicts between the upcoming PTP aux_work and the queue creation/destruction adminq commands (Jakub Kicinski)
- add the missing READ_ONCE (Joe Damato)
Harshitha Ramamurthy (1):
gve: Add initial PTP device support
John Fraker (5):
gve: Add device option for nic clock synchronization
gve: Add adminq command to report nic timestamp
gve: Add rx hardware timestamp expansion
gve: Implement ndo_hwtstamp_get/set for RX timestamping
gve: Advertise support for rx hardware timestamping
Kevin Yang (1):
gve: Add support to query the nic clock
Ziwei Xiao (1):
gve: Add adminq lock for queues creation and destruction
drivers/net/ethernet/google/Kconfig | 1 + drivers/net/ethernet/google/gve/Makefile | 4 +- drivers/net/ethernet/google/gve/gve.h | 35 +++++ drivers/net/ethernet/google/gve/gve_adminq.c | 98 ++++++++++-- drivers/net/ethernet/google/gve/gve_adminq.h | 28 ++++ .../net/ethernet/google/gve/gve_desc_dqo.h | 3 +- drivers/net/ethernet/google/gve/gve_ethtool.c | 26 +++- drivers/net/ethernet/google/gve/gve_main.c | 53 ++++++- drivers/net/ethernet/google/gve/gve_ptp.c | 139 ++++++++++++++++++ drivers/net/ethernet/google/gve/gve_rx_dqo.c | 26 ++++ 10 files changed, 396 insertions(+), 17 deletions(-) create mode 100644 drivers/net/ethernet/google/gve/gve_ptp.c
Signature · 1 line
2.50.0.rc1.591.g9c95f17f64-goog