Skip to content

net/mlx5: HWS, Improve IP version handling

Mark Bloch linux-rdma lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3net/mlx5: HWS, Fix IP version decisiondrivers/net/ethernet/mellanox/mlx5/core/steering/hws/definer.c+16 -220 repliesApplied
2/3net/mlx5: HWS, Harden IP version definer checksdrivers/net/ethernet/mellanox/mlx5/core/steering/hws/definer.c+42 -20 repliesApplied
3/3net/mlx5: HWS, Disallow matcher IP version mixingdrivers/net/ethernet/mellanox/mlx5/core/steering/hws/matcher.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/matcher.h drivers/net/ethernet/mellanox/mlx5/core/steering/hws/rule.c+160 -00 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchYevgeny Kliteynik
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/3] net/mlx5: HWS, Improve IP version handling

This small series hardens our checks against a single matcher containing rules that match on IPv4 and IPv6. This scenario is not supported by hardware steering and the implementation now signals this instead of failing silently.

Patches:
* Patch 1 forbids a single definer to match on mixed IP versions for source and destination address.
* Patch 2 reproduces a couple of firmware checks: it forbids creating a definer that matches on IP address without matching on IP version, and also disallows matching on IPv6 addresses and the IPv4 IHL fields in the same definer.
* Patch 3 forbids mixing rules that match on IPv4 and IPv6 addresses in the same matcher. The underlying definer mechanism does not support that.

Thanks,
Mark

Vlad Dogaru (3):
net/mlx5: HWS, Fix IP version decision net/mlx5: HWS, Harden IP version definer checks net/mlx5: HWS, Disallow matcher IP version mixing

 .../mellanox/mlx5/core/steering/hws/definer.c |  78 +++++++----
 .../mellanox/mlx5/core/steering/hws/matcher.c |  26 ++++
 .../mellanox/mlx5/core/steering/hws/matcher.h |  12 ++
 .../mellanox/mlx5/core/steering/hws/rule.c    | 122 ++++++++++++++++++
 4 files changed, 216 insertions(+), 22 deletions(-)

base-commit: 07e32237ed9d3f5815fb900dee9458b5f115a678

Signature · 1 line
2.34.1