Skip to content

rtc: pm8xxx: fix uefi offset lookup

Johan Hovold linux-arm-msm linux-devicetree linux-rtc lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4dt-bindings: rtc: qcom-pm8xxx: add uefi-variable offsetDocumentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml+6 -01 reply
2/4rtc: pm8xxx: fix uefi offset lookupdrivers/rtc/rtc-pm8xxx.c+12 -50 replies
3/4arm64: dts: qcom: sc8280xp-x13s: describe uefi rtc offsetarch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts+2 -00 replies
4/4arm64: dts: qcom: x1e80100: describe uefi rtc offsetarch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi+1 -00 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchRob Herring (Arm)
1/4A-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] rtc: pm8xxx: fix uefi offset lookup

On many Qualcomm platforms the PMIC RTC control and time registers are read-only so that the RTC time can not be updated. Instead an offset needs be stored in some machine-specific non-volatile memory, which a driver can take into account.

On platforms where the offset is stored in a Qualcomm specific UEFI variable the variables are also accessed in a non-standard way, which means that the OS cannot assume that the variable service is available by the time the driver probes.

This series adds a 'qcom,uefi-rtc-info' boolean DT property to indicate that the RTC offset is stored in a Qualcomm specific UEFI variable so that the OS can determine whether to wait for it to become available.

I used such a property in v1 of the series adding support for the UEFI offset [1], but mistakenly convinced myself that it was not needed given that the efivars driver would need to remain built in. As Rob Clark noticed, this is however not sufficient and the driver can currently fail to look up the offset if the RTC driver is built in or if a dependency of the efivars driver is built as a module. [2]

As with the rest of this driver, hopefully all of this goes away (for future platforms) once Qualcomm fix their UEFI implementation so that the time service can be used directly.

Preferably the binding and driver fix can be merged for 6.15-rc by Alexandre, while Bjorn takes the DT changes through the branch which has the DT patches from v2 (which unfortunately missed 6.15 but may possibly be sent as hw enablement fixups). [3]

Johan

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://lore.kernel.org/lkml/[email protected]/

Johan Hovold (4):
dt-bindings: rtc: qcom-pm8xxx: add uefi-variable offset
rtc: pm8xxx: fix uefi offset lookup
arm64: dts: qcom: sc8280xp-x13s: describe uefi rtc offset
arm64: dts: qcom: x1e80100: describe uefi rtc offset

 .../bindings/rtc/qcom-pm8xxx-rtc.yaml           |  6 ++++++
 .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts  |  2 ++
 arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi    |  1 +
 drivers/rtc/rtc-pm8xxx.c                        | 17 ++++++++++++-----
 4 files changed, 21 insertions(+), 5 deletions(-)
Signature · 1 line
2.49.0