Skip to content

xsk: respect the offsets when copying frags

Bui Quang Minh bpf lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesApplied 2/2
  2. v11 patch 8 repliesSuperseded

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2xsk: respect the offsets when copying fragsnet/core/xdp.c+4 -30 repliesApplied
2/2xsk: convert xdp_copy_frags_from_zc() to use page_pool_dev_alloc()net/core/xdp.c+7 -70 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/2] xsk: respect the offsets when copying frags

Hi everyone,

In commit 560d958c6c68 ("xsk: add generic XSk &xdp_buff -> skb conversion"), we introduce a helper to convert zerocopy xdp_buff to skb. However, in the frag copy, we mistakenly ignore the frag's offset. This series adds the missing offset when copying frags in xdp_copy_frags_from_zc(). This function is not used anywhere so no backport is needed.

This series also makes xdp_copy_frags_from_zc() use page allocation API page_pool_dev_alloc() instead of page_pool_dev_alloc_netmem() to avoid possible confusion of the returned value.

Thanks,
Quang Minh.

Bui Quang Minh (2):
xsk: respect the offsets when copying frags
xsk: convert xdp_copy_frags_from_zc() to use page_pool_dev_alloc()

 net/core/xdp.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.0