tools: ynl-gen: additional C types and classic netlink handling
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest12 patches 0 repliesNew 11 of 12 applied
- v212 patches 13 repliesSuperseded
- v112 patches 14 repliesSuperseded
Changes in v3 from the cover letter
- [patch 7] fix typo in a comment
- [patch 11] improve grammar of a comment
v2: https://lore.kernel.org/[email protected]
- [patch 3] use Jake's suggestion
- [patch 11] move comment
v1: https://lore.kernel.org/[email protected]
Patches in v3 11 of 12 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | tools: ynl-gen: fix comment about nested struct dicttools/ | +1 | 0 replies | Applied |
| 2/12 | tools: ynl-gen: factor out free_needs_iter for a structtools/ | +9 | 0 replies | Applied |
| 3/12 | tools: ynl-gen: fill in missing empty attr liststools/ | +8 | 0 replies | Applied |
| 4/12 | tools: ynl: let classic netlink requests specify extra nlflagstools/ tools/ tools/ | +23 | 0 replies | Applied |
| 5/12 | tools: ynl-gen: support using dump types for ntftools/ | +1 | 0 replies | Applied |
| 6/12 | tools: ynl-gen: support CRUD-like notifications for classic Netlinktools/ | +5 | 0 replies | Applied |
| 7/12 | tools: ynl-gen: multi-attr: type gen for stringtools/ tools/ | +38 | 0 replies | Applied |
| 8/12 | tools: ynl-gen: mutli-attr: support binary types with structtools/ | +19 | 0 replies | Applied |
| 9/12 | tools: ynl-gen: array-nest: support put for scalartools/ | +25 | 0 replies | Applied |
| 10/12 | tools: ynl-gen: array-nest: support binary array with exact-lentools/ | +20 | 0 replies | Applied |
| 11/12 | tools: ynl-gen: don't init enum checks for classic netlinktools/ | +26 | 0 replies | Applied |
| 12/12 | tools: ynl: allow fixed-header to be specified per optools/ tools/ tools/ | +21 | 0 replies |
Reviews trailers per patch
All 12 patches have a Reviewed-by or Acked-by.
| Patch | Donald Hunter | Jacob Keller |
|---|---|---|
| 1/12 | R-b | R-b |
| 2/12 | R-b | R-b |
| 3/12 | R-b | R-b |
| 4/12 | R-b | R-b |
| 5/12 | R-b | R-b |
| 6/12 | R-b | R-b |
| 7/12 | R-b | R-b |
| 8/12 | R-b | R-b |
| 9/12 | R-b | R-b |
| 10/12 | R-b | R-b |
| 11/12 | R-b | |
| 12/12 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v3 00/12] tools: ynl-gen: additional C types and classic netlink handling
This series is a bit of a random grab bag adding things we need to generate code for rt-link.
First two patches are pretty random code cleanups.
Patch 3 adds default values if the spec is missing them.
Patch 4 adds support for setting Netlink request flags (NLM_F_CREATE, NLM_F_REPLACE etc.). Classic netlink uses those quite a bit.
Patches 5 and 6 extend the notification handling for variations used in classic netlink. Patch 6 adds support for when notification ID is the same as the ID of the response message to GET.
Next 4 patches add support for handling a couple of complex types. These are supported by the schema and Python but C code gen wasn't there.
Patch 11 is a bit of a hack, it skips code related to kernel policy generation, since we don't need it for classic netlink.
Patch 12 adds support for having different fixed headers per op. Something we could avoid in previous rtnetlink specs but some specs do mix.
v3:
- [patch 7] fix typo in a comment
- [patch 11] improve grammar of a comment
v2: https://lore.kernel.org/[email protected]
- [patch 3] use Jake's suggestion
- [patch 11] move comment
v1: https://lore.kernel.org/[email protected]
Jakub Kicinski (12):
tools: ynl-gen: fix comment about nested struct dict
tools: ynl-gen: factor out free_needs_iter for a struct
tools: ynl-gen: fill in missing empty attr lists
tools: ynl: let classic netlink requests specify extra nlflags
tools: ynl-gen: support using dump types for ntf
tools: ynl-gen: support CRUD-like notifications for classic Netlink
tools: ynl-gen: multi-attr: type gen for string
tools: ynl-gen: mutli-attr: support binary types with struct
tools: ynl-gen: array-nest: support put for scalar
tools: ynl-gen: array-nest: support binary array with exact-len
tools: ynl-gen: don't init enum checks for classic netlink
tools: ynl: allow fixed-header to be specified per op
tools/net/ynl/lib/ynl-priv.h | 2 +- tools/net/ynl/lib/ynl.h | 14 ++ tools/net/ynl/lib/ynl.c | 12 +- tools/net/ynl/pyynl/ynl_gen_c.py | 216 +++++++++++++++++++++++++------ 4 files changed, 196 insertions(+), 48 deletions(-)
Signature · 1 line
2.49.0