perf: Deferred unwinding of user space stack traces
Get series with b4
b4 am [email protected]Versions newest first
- v5 Latest17 patches 26 repliesIn review
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | unwind_user: Add user space unwinding APIMAINTAINERS arch/ include/ +4 more | +114 | 0 replies | |
| 2/17 | unwind_user: Add frame pointer supportarch/ include/ include/ +1 more | +63 | 0 replies | |
| 3/17 | unwind_user/x86: Enable frame pointer unwinding on x86arch/ arch/ | +12 | 0 replies | |
| 4/17 | perf/x86: Rename and move get_segment_base() and make it globalarch/ arch/ arch/ | +45 | 0 replies | |
| 5/17 | unwind_user: Add compat mode frame pointer supportarch/ include/ include/ +3 more | +65 | 0 replies | |
| 6/17 | unwind_user/x86: Enable compat mode frame pointer unwinding on x86arch/ arch/ arch/ | +68 | 0 replies | |
| 7/17 | unwind_user/deferred: Add unwind_deferred_trace()include/ include/ include/ +3 more | +92 | 0 replies | |
| 8/17 | unwind_user/deferred: Add unwind cacheinclude/ include/ include/ +1 more | +35 | 1 reply | |
| 9/17 | perf: Remove get_perf_callchain() init_nr argumentinclude/ kernel/ kernel/ +1 more | +10 | 0 replies | |
| 10/17 | perf: Have get_perf_callchain() return NULL if crosstask and user are setkernel/ | +4 | 0 replies | |
| 11/17 | perf: Simplify get_perf_callchain() user logickernel/ | +9 | 5 replies | |
| 12/17 | perf: Skip user unwind if !current->mmkernel/ | +1 | 2 replies | |
| 13/17 | perf: Support deferred user callchainsarch/ include/ include/ +4 more | +224 | 15 replies | |
| 14/17 | perf tools: Minimal CALLCHAIN_DEFERRED supporttools/ tools/ tools/ +6 more | +47 | 0 replies | |
| 15/17 | perf record: Enable defer_callchain for user callchainstools/ tools/ | +25 | 0 replies | |
| 16/17 | perf script: Display PERF_RECORD_CALLCHAIN_DEFERREDtools/ | +89 | 0 replies | |
| 17/17 | perf tools: Merge deferred user callchainstools/ tools/ tools/ +6 more | +102 | 0 replies |
Reviews trailers per patch
2 of 17 patches have a Reviewed-by or Acked-by.
| Patch | Namhyung Kim |
|---|---|
| 1/17 | |
| 2/17 | |
| 3/17 | |
| 4/17 | |
| 5/17 | |
| 6/17 | |
| 7/17 | |
| 8/17 | |
| 9/17 | A-b |
| 10/17 | |
| 11/17 | A-b |
| 12/17 | |
| 13/17 | |
| 14/17 | |
| 15/17 | |
| 16/17 | |
| 17/17 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 00/17] perf: Deferred unwinding of user space stack traces
I'm currently working on getting sframe support from the kernel. Josh Poimboeuf did a lot of the hard work already, but he told me he doesn't have time to continue it so I'm picking it up where he left off.
His last series of v4 is here:
https://lore.kernel.org/all/[email protected]/
It covers a lot of topics as he found issues with other aspects of the kernel that needed to be fixed for sframes to work properly.
This series focuses only on implementing the deferred user space stack tracing that can be used by perf. It does not implement sframe support nor does it add an interface that can be used by ftrace or LTTng (that will come later).
I based this off of the latest tip/master:
commit 7ab869c799fc0fb22f9b4c2f36aaa603d9c7cc9d
A new generic interface is created for user space stack tracing. It does not replace the current stack_trace_save_user() interface, but creates a new interface that can handle more complex tasks. For instance, deferred stack tracing.
Josh's code had an interface with:
unwind_deferred_init()
unwind_deferred_request()
unwind_deferred_cancel()
That is not in this series.
That code made it possible for a tracer to register that it will be wanting to have user space stacktraces and give it a callback to call when the task goes back to user space. An interface to request a stacktrace and is given a "cookie" that will be used to map it to the stacktrace that will be retrieved when the task exits. And an interface to unregister (cancel).
But that is not in this series. This adds a new interface that is called by the tracer from a faultable context and gets the user space stack trace immediately. It also has the cache logic where if the same stacktrace is requested more than once (possibly by different requesters) it doesn't have to regenerate the trace.
The new function is:
unwind_deferred_trace()
Since perf is unique from other tracers where it has a separate event for basically every task and/or every event and can have hundreds of requesters for a task stack trace, I found it was just better to have perf use its own setup with a task_work per event. This is very similar to what Josh did with his last version within the above three functions. But since that was not very useful for ftrace or LTTng, and perf didn't need the cookie concept, I decided to just implement that directly within perf. That made the unwinder code simpler for this version.
Josh Poimboeuf (12):
unwind_user: Add user space unwinding API
unwind_user: Add frame pointer support
unwind_user/x86: Enable frame pointer unwinding on x86
perf/x86: Rename and move get_segment_base() and make it global
unwind_user: Add compat mode frame pointer support unwind_user/x86: Enable compat mode frame pointer unwinding on x86 unwind_user/deferred: Add unwind cache
perf: Remove get_perf_callchain() 'init_nr' argument
perf: Have get_perf_callchain() return NULL if 'crosstask' and 'user' are set
perf: Simplify get_perf_callchain() user logic
perf: Skip user unwind if !current->mm
perf: Support deferred user callchains
Namhyung Kim (4):
perf tools: Minimal CALLCHAIN_DEFERRED support perf record: Enable defer_callchain for user callchains perf script: Display PERF_RECORD_CALLCHAIN_DEFERRED perf tools: Merge deferred user callchains
Steven Rostedt (1):
unwind_user/deferred: Add unwind_deferred_trace()
----
MAINTAINERS | 8 ++ arch/Kconfig | 14 +++ arch/x86/Kconfig | 2 + arch/x86/events/core.c | 44 +------- arch/x86/include/asm/ptrace.h | 2 + arch/x86/include/asm/unwind_user.h | 61 +++++++++++ arch/x86/include/asm/unwind_user_types.h | 17 +++ arch/x86/kernel/ptrace.c | 38 +++++++ include/asm-generic/Kbuild | 2 + include/asm-generic/unwind_user.h | 24 +++++ include/asm-generic/unwind_user_types.h | 9 ++ include/linux/entry-common.h | 2 + include/linux/perf_event.h | 15 ++- include/linux/sched.h | 5 + include/linux/unwind_deferred.h | 31 ++++++ include/linux/unwind_deferred_types.h | 14 +++ include/linux/unwind_user.h | 15 +++ include/linux/unwind_user_types.h | 35 +++++++ include/uapi/linux/perf_event.h | 19 +++- kernel/Makefile | 1 + kernel/bpf/stackmap.c | 8 +- kernel/events/callchain.c | 47 +++++---- kernel/events/core.c | 165 +++++++++++++++++++++++++++++- kernel/fork.c | 4 + kernel/unwind/Makefile | 1 + kernel/unwind/deferred.c | 62 +++++++++++ kernel/unwind/user.c | 130 +++++++++++++++++++++++ tools/include/uapi/linux/perf_event.h | 19 +++- tools/lib/perf/include/perf/event.h | 7 ++ tools/perf/Documentation/perf-script.txt | 5 + tools/perf/builtin-script.c | 92 +++++++++++++++++ tools/perf/util/callchain.c | 24 +++++ tools/perf/util/callchain.h | 3 + tools/perf/util/event.c | 1 + tools/perf/util/evlist.c | 1 + tools/perf/util/evlist.h | 1 + tools/perf/util/evsel.c | 39 +++++++ tools/perf/util/evsel.h | 1 + tools/perf/util/machine.c | 1 + tools/perf/util/perf_event_attr_fprintf.c | 1 + tools/perf/util/sample.h | 3 +- tools/perf/util/session.c | 78 ++++++++++++++ tools/perf/util/tool.c | 2 + tools/perf/util/tool.h | 4 +- 44 files changed, 985 insertions(+), 72 deletions(-) create mode 100644 arch/x86/include/asm/unwind_user.h create mode 100644 arch/x86/include/asm/unwind_user_types.h create mode 100644 include/asm-generic/unwind_user.h create mode 100644 include/asm-generic/unwind_user_types.h create mode 100644 include/linux/unwind_deferred.h create mode 100644 include/linux/unwind_deferred_types.h create mode 100644 include/linux/unwind_user.h create mode 100644 include/linux/unwind_user_types.h create mode 100644 kernel/unwind/Makefile create mode 100644 kernel/unwind/deferred.c create mode 100644 kernel/unwind/user.c