Skip to content

ipmi: Remove SRCU and handle the fallout

Corey Minyard lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest23 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23ipmi:msghandler: Use READ_ONCE on run_to_completiondrivers/char/ipmi/ipmi_msghandler.c+8 -90 replies
2/23ipmi:msghandler: Rename recv_work to smi_workdrivers/char/ipmi/ipmi_msghandler.c+10 -100 replies
3/23ipmi:msghandler: Move timer handling into a work queuedrivers/char/ipmi/ipmi_msghandler.c+15 -10 replies
4/23ipmi:msghandler: Deliver user messages in a work queuedrivers/char/ipmi/ipmi_msghandler.c+25 -160 replies
5/23ipmi_msghandler: Change the events lock to a mutexdrivers/char/ipmi/ipmi_msghandler.c+6 -80 replies
6/23ipmi:msghandler: Use the system_wq, not system_bh_wqdrivers/char/ipmi/ipmi_msghandler.c+5 -50 replies
7/23ipmi:msghandler: Remove srcu from the ipmi user structuredrivers/char/ipmi/ipmi_msghandler.c+133 -1770 replies
8/23ipmi:msghandler: Remove srcu for the ipmi_interfaces listdrivers/char/ipmi/ipmi_msghandler.c+102 -920 replies
9/23ipmi:watchdog: Change lock to mutexdrivers/char/ipmi/ipmi_watchdog.c+9 -110 replies
10/23ipmi: Add a note about the pretimeout callbackinclude/linux/ipmi.h+2 -10 replies
11/23ipmi:msghandler: Remove some user level processing in panic modedrivers/char/ipmi/ipmi_msghandler.c+4 -00 replies
12/23ipmi:msghandler: Fix locking around users and interfacesdrivers/char/ipmi/ipmi_msghandler.c+25 -260 replies
13/23ipmi:msghandler: Don't acquire a user refcount for queued messagesdrivers/char/ipmi/ipmi_msghandler.c+17 -150 replies
14/23ipmi:msghandler: Don't check for shutdown when returning responsesdrivers/char/ipmi/ipmi_msghandler.c+12 -220 replies
15/23ipmi:msghandler: Remove proc_fs.hdrivers/char/ipmi/ipmi_msghandler.c+0 -10 replies
16/23ipmi:msghandler: Shut down lower layer first at unregisterdrivers/char/ipmi/ipmi_msghandler.c+7 -40 replies
17/23ipmi:msghandler: Add a error return from unhandle LAN cmdsdrivers/char/ipmi/ipmi_msghandler.c+23 -40 replies
18/23ipmi:si: Rework startup of IPMI devicesdrivers/char/ipmi/ipmi_si_intf.c+62 -200 replies
19/23ipmi:msghandler: Don't deliver messages to deleted usersdrivers/char/ipmi/ipmi_msghandler.c+26 -20 replies
20/23ipmi:ssif: Fix a shutdown racedrivers/char/ipmi/ipmi_ssif.c+1 -50 replies
21/23Documentation:ipmi: Remove comments about interrupt levelDocumentation/driver-api/ipmi.rst+3 -60 replies
22/23ipmi:msghandler: Export and fix panic messaging capabilitydrivers/char/ipmi/ipmi_msghandler.c include/linux/ipmi.h+41 -190 replies
23/23ipmi:watchdog: Use the new interface for panic messagesdrivers/char/ipmi/ipmi_watchdog.c+17 -550 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/23] ipmi: Remove SRCU and handle the fallout

This patch set switches from SRCU to using normal locks. This required pulling most of the IPMI message handler up to run in kernel threads, which was a good thing, anyway. It also handles some fallout from that change.

I didn't have a way to thoroughly test the IPMI driver, most of the work for this was creating a test framework, which required work in QEMU, the OpenIPMI simulator, and a few other things. But that's working now, and it shook out surprisingly few bugs, one in the new changes and one driver unload issue.

Anyway, here's the first candidate for this.