Skip to content

Add SDHCI_QUIRK2_SUPPRESS_V1P8_ENA

Judith Mendez linux-mmc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest2 patches 3 repliesIn review

Changes in v4 from the cover letter

- apply the quirk based on compatible string instead of based on bus width or DT property
- rephrase commit descriptions and cover-letter descriptions based on new implementation.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mmc: sdhci: Add a quirk for suppressing V1P8_SIGNAL_ENAdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+7 -30 replies
2/2mmc: sdhci_am654: Add SDHCI_QUIRK2_SUPPRESS_V1P8_ENA quirk to am62 compatibledrivers/mmc/host/sdhci_am654.c+13 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] Add SDHCI_QUIRK2_SUPPRESS_V1P8_ENA

There are MMC boot failures seen with V1P8_SIGNAL_ENA on Kingston eMMC and Microcenter/Patriot SD cards on am62* Sitara K3 boards due to the HS200 initialization sequence involving V1P8_SIGNAL_ENA. Since V1P8_SIGNAL_ENA is optional for eMMC and only affects timing for host controllers using ti,am62-sdhci compatible so far, add a new platform data structure for am62 compatible and append the new SDHCI_QUIRK2_SUPPRESS_V1P8_ENA quirk.

This fix was previously merged in the kernel, but was reverted due to the "heuristics for enabling the quirk"[0]. This issue is adressed in this patch series by adding the quirk based on compatible string, ensuring the quirk is never applied to devices with internal LDOs, then V1P8_SIGNAL_ENA also has a voltage component tied to it.

Changes since v3 RESEND:
- apply the quirk based on compatible string instead of based on bus width or DT property
- rephrase commit descriptions and cover-letter descriptions based on new implementation.

Link to v3 RESEND:
https://lore.kernel.org/linux-mmc/[email protected]
Link to v2:
https://lore.kernel.org/linux-mmc/[email protected]/
Link to v1:
https://lore.kernel.org/linux-mmc/[email protected]/

[0] https://lore.kernel.org/linux-mmc/[email protected]/

Judith Mendez (2):
mmc: sdhci: Add a quirk for suppressing V1P8_SIGNAL_ENA
mmc: sdhci_am654: Add SDHCI_QUIRK2_SUPPRESS_V1P8_ENA quirk to am62
compatible

 drivers/mmc/host/sdhci.c       |  8 +++++---
 drivers/mmc/host/sdhci.h       |  2 ++
 drivers/mmc/host/sdhci_am654.c | 14 +++++++++++++-
 3 files changed, 20 insertions(+), 4 deletions(-)

base-commit: 1be38f81251f6d276713c259ecf4414f82f22c29

Signature · 1 line
2.49.0