Skip to content

unwind_deferred: Implement sframe handling

Steven Rostedt bpf linux-mm linux-trace-kernel lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest12 patches 3 repliesIn review
  2. v612 patches 1 replySuperseded
  3. v512 patches 2 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12unwind_user/sframe: Add support for reading .sframe headersMAINTAINERS arch/Kconfig include/linux/sframe.h +3 more+253 -10 replies
2/12unwind_user/sframe: Store sframe section data in per-mm maple treearch/x86/include/asm/mmu.h include/linux/mm_types.h include/linux/sframe.h +3 more+81 -40 replies
3/12x86/uaccess: Add unsafe_copy_from_user() implementationarch/x86/include/asm/uaccess.h+29 -100 replies
4/12unwind_user/sframe: Add support for reading .sframe contentsinclude/linux/sframe.h kernel/unwind/sframe.c kernel/unwind/sframe_debug.h+347 -40 replies
5/12unwind_user/sframe: Detect .sframe sections in executablesfs/binfmt_elf.c include/uapi/linux/elf.h+47 -30 replies
6/12unwind_user/sframe: Wire up unwind_user to sframearch/Kconfig include/linux/unwind_user_types.h kernel/unwind/user.c+24 -30 replies
7/12unwind_user/sframe/x86: Enable sframe unwinding on x86arch/x86/Kconfig+1 -00 replies
8/12unwind_user/sframe: Remove .sframe section on detected corruptionkernel/unwind/sframe.c+4 -00 replies
9/12unwind_user/sframe: Show file name in debug outputinclude/linux/sframe.h kernel/unwind/sframe.c kernel/unwind/sframe_debug.h+56 -160 replies
10/12unwind_user/sframe: Enable debugging in uaccess regionskernel/unwind/sframe.c kernel/unwind/sframe_debug.h+78 -130 replies
11/12unwind_user/sframe: Add .sframe validation optionarch/Kconfig kernel/unwind/sframe.c+100 -00 replies
12/12unwind_user/sframe: Add prctl() interface for registering .sframe sectionsinclude/uapi/linux/prctl.h kernel/sys.c+14 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [PATCH v7 00/12] unwind_deferred: Implement sframe handling

This code is based on top of:

https://lore.kernel.org/linux-trace-kernel/[email protected]/
git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git unwind/core

This is the implementation of parsing the SFrame section in an ELF file. It's a continuation of Josh's last work that can be found here:

https://lore.kernel.org/all/[email protected]/

Currently the only way to get a user space stack trace from a stack walk (and not just copying large amount of user stack into the kernel ring buffer) is to use frame pointers. This has a few issues. The biggest one is that compiling frame pointers into every application and library has been shown to cause performance overhead.

Another issue is that the format of the frames may not always be consistent between different compilers and some architectures (s390) has no defined format to do a reliable stack walk. The only way to perform user space profiling on these architectures is to copy the user stack into the kernel buffer.

SFrames[1] is now supported in gcc binutils and soon will also be supported by LLVM. SFrames acts more like ORC, and lives in the ELF executable file as its own section. Like ORC it has two tables where the first table is sorted by instruction pointers (IP) and using the current IP and finding it's entry in the first table, it will take you to the second table which will tell you where the return address of the current function is located and then you can use that address to look it up in the first table to find the return address of that function, and so on. This performs a user space stack walk.

Now because the SFrame section lives in the ELF file it needs to be faulted into memory when it is used. This means that walking the user space stack requires being in a faultable context. As profilers like perf request a stack trace in interrupt or NMI context, it cannot do the walking when it is requested. Instead it must be deferred until it is safe to fault in user space. One place this is known to be safe is when the task is about to return back to user space.

This series makes the deferred unwind code implement SFrames.

[1] https://sourceware.org/binutils/wiki/sframe

The code for this patch series can be found here:

git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git unwind/sframe

Changes since v6: https://lore.kernel.org/linux-trace-kernel/[email protected]/

- Rebased on top of unwind/core

- Moved the addition of the prctl(), that allows libraries to add the elf sections to the kernel, to the last patch and labeled it as "DO NOT APPLY". This should instead be a proper system call and work to make it robust and flexible still needs to be done. The prctl() patch is added for debugging purposes only.

Head SHA1: 5d24854c7069f833449e8310bd3253624213c08d

Josh Poimboeuf (12):
unwind_user/sframe: Add support for reading .sframe headers unwind_user/sframe: Store sframe section data in per-mm maple tree x86/uaccess: Add unsafe_copy_from_user() implementation unwind_user/sframe: Add support for reading .sframe contents unwind_user/sframe: Detect .sframe sections in executables unwind_user/sframe: Wire up unwind_user to sframe
unwind_user/sframe/x86: Enable sframe unwinding on x86
unwind_user/sframe: Remove .sframe section on detected corruption unwind_user/sframe: Show file name in debug output
unwind_user/sframe: Enable debugging in uaccess regions unwind_user/sframe: Add .sframe validation option
[DO NOT APPLY] unwind_user/sframe: Add prctl() interface for registering .sframe sections

----

 MAINTAINERS                       |   1 +
 arch/Kconfig                      |  23 ++
 arch/x86/Kconfig                  |   1 +
 arch/x86/include/asm/mmu.h        |   2 +-
 arch/x86/include/asm/uaccess.h    |  39 ++-
 fs/binfmt_elf.c                   |  49 ++-
 include/linux/mm_types.h          |   3 +
 include/linux/sframe.h            |  60 ++++
 include/linux/unwind_user_types.h |   1 +
 include/uapi/linux/elf.h          |   1 +
 include/uapi/linux/prctl.h        |   6 +-
 kernel/fork.c                     |  10 +
 kernel/sys.c                      |   9 +
 kernel/unwind/Makefile            |   3 +-
 kernel/unwind/sframe.c            | 612 ++++++++++++++++++++++++++++++++++++++
 kernel/unwind/sframe.h            |  71 +++++
 kernel/unwind/sframe_debug.h      |  99 ++++++
 kernel/unwind/user.c              |  25 +-
 mm/init-mm.c                      |   2 +
 19 files changed, 998 insertions(+), 19 deletions(-)
 create mode 100644 include/linux/sframe.h
 create mode 100644 kernel/unwind/sframe.c
 create mode 100644 kernel/unwind/sframe.h
 create mode 100644 kernel/unwind/sframe_debug.h