Skip to content

rtlwifi deadcoding

[email protected] linux-wireless lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3wifi: rtlwifi: Remove unused rtl_usb_{resume|suspend}drivers/net/wireless/realtek/rtlwifi/usb.c drivers/net/wireless/realtek/rtlwifi/usb.h+0 -143 replies
2/3wifi: rtlwifi: Remove uncalled stub rtl*_phy_ap_calibratedrivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.h drivers/net/wireless/realtek/rtlwifi/rtl8192du/phy.c +5 more+0 -220 replies
3/3wifi: rtlwifi: Remove unused rtl_bb_delay()drivers/net/wireless/realtek/rtlwifi/core.c drivers/net/wireless/realtek/rtlwifi/core.h+0 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] rtlwifi deadcoding

From: "Dr. David Alan Gilbert" <[email protected]>

Hi,
A bunch of small deadcode cleanups for unused functions, many
of which are empty anyway.

However, one odd thing I noticed while preparing these is
rtl8188ee_bt_hw_init() in drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c isn't called - lots of the other models have similarly named functions that are called; is that a bug just forgetting to call it?

Dave

Dr. David Alan Gilbert (3):
wifi: rtlwifi: Remove unused rtl_usb_{resume|suspend}
wifi: rtlwifi: Remove uncalled stub rtl*_phy_ap_calibrate
wifi: rtlwifi: Remove unused rtl_bb_delay()

 drivers/net/wireless/realtek/rtlwifi/core.c          | 11 -----------
 drivers/net/wireless/realtek/rtlwifi/core.h          |  1 -
 drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c |  5 -----
 drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.h |  1 -
 drivers/net/wireless/realtek/rtlwifi/rtl8192du/phy.c |  5 -----
 drivers/net/wireless/realtek/rtlwifi/rtl8192du/phy.h |  1 -
 drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c |  4 ----
 drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.h |  1 -
 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c |  4 ----
 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.h |  1 -
 drivers/net/wireless/realtek/rtlwifi/usb.c           | 12 ------------
 drivers/net/wireless/realtek/rtlwifi/usb.h           |  2 --
 12 files changed, 48 deletions(-)
Signature · 1 line
2.49.0