Skip to content

ublk: simplify NEED_GET_DATA handling and request lookup

Caleb Sander Mateos linux-block lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 3 repliesApplied
  2. v18 patches 12 repliesSuperseded

Changes in v2 from the cover letter

- Don't complete uring_cmd if ublk_map_io() returns 0 (Ming)
- Take const ubq pointers

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/9ublk: factor out ublk_commit_and_fetchdrivers/block/ublk_drv.c+43 -470 replies
2/9ublk: fix "immepdately" typo in commentdrivers/block/ublk_drv.c+1 -10 replies
3/9ublk: remove misleading "ubq" in "ubq_complete_io_cmd()"drivers/block/ublk_drv.c+5 -40 replies
4/9ublk: take const ubq pointer in ublk_get_iod()drivers/block/ublk_drv.c+7 -81 reply
5/9ublk: don't log uring_cmd cmd_op in ublk_dispatch_req()drivers/block/ublk_drv.c+6 -70 replies
6/9ublk: factor out ublk_start_io() helperdrivers/block/ublk_drv.c+31 -231 reply
7/9ublk: don't call ublk_dispatch_req() for NEED_GET_DATAdrivers/block/ublk_drv.c+29 -220 replies
8/9ublk: check UBLK_IO_FLAG_OWNED_BY_SRV in ublk_abort_queue()drivers/block/ublk_drv.c+2 -70 replies
9/9ublk: store request pointer in ublk_iodrivers/block/ublk_drv.c+24 -190 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchCaleb Sander MateosMing Lei
1/9R-b R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] ublk: simplify NEED_GET_DATA handling and request lookup

Remove accesses to ublk_io's cmd field after the I/O request is posted to the ublk server. This allows the cmd field to be overlapped with a pointer to the struct request, avoiding several blk_mq_tag_to_rq() lookups.

Fix a couple of typos noticed along the way.

Caleb Sander Mateos (8):
ublk: fix "immepdately" typo in comment
ublk: remove misleading "ubq" in "ubq_complete_io_cmd()"
ublk: take const ubq pointer in ublk_get_iod()
ublk: don't log uring_cmd cmd_op in ublk_dispatch_req()
ublk: factor out ublk_start_io() helper
ublk: don't call ublk_dispatch_req() for NEED_GET_DATA
ublk: check UBLK_IO_FLAG_OWNED_BY_SRV in ublk_abort_queue()
ublk: store request pointer in ublk_io

Uday Shankar (1):
ublk: factor out ublk_commit_and_fetch

 drivers/block/ublk_drv.c | 252 ++++++++++++++++++++-------------------
 1 file changed, 131 insertions(+), 121 deletions(-)

v2:
- Don't complete uring_cmd if ublk_map_io() returns 0 (Ming)
- Take const ubq pointers

Signature · 1 line
2.45.2