Skip to content

RFC Revival of patches to implement NBD client multi-conn

Eric Blake qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 RFC Latest4 patches 17 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4nbd: Add multi-conn optionblock/nbd.c qapi/block-core.json+31 -111 replies
2/4nbd: Split out block device state from underlying NBD connectionsblock/coroutines.h block/nbd.c+356 -3200 replies
3/4nbd: Open multiple NBD connections if multi-conn is setblock/nbd.c+90 -380 replies
4/4nbd: Enable multi-conn using round-robinblock/nbd.c+49 -184 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC PATCH v2 0/4] Revival of patches to implement NBD client multi-conn

This is a rebase of patches that Rich Jones first posted in 2023:
https://lists.gnu.org/archive/html/qemu-devel/2023-03/msg03320.html

I'm still leaving the series in an RFC state while I'm trying to improve the code to better play with all of the multi-queue changes in the block layer in the meantime. In my own testing, the patches as presented here are not making any noticeable difference in qemu-img convert to a local destination file (multi-conn=1 was not much different than multi-conn=4, although I did validate that multiple sockets were in use and the round robin code was working). Other benchmarks did show improvements, such as qemu convert targeting an nbdkit server on a curl backend getting a 20% boost when I ramped multi-conn from 1 to 4.

I have more patches on top of these to post to the list once I can get benchmark numbers that make more sense.

Richard W.M. Jones (4):
nbd: Add multi-conn option
nbd: Split out block device state from underlying NBD connections
nbd: Open multiple NBD connections if multi-conn is set
nbd: Enable multi-conn using round-robin

 qapi/block-core.json |   8 +-
 block/coroutines.h   |   5 +-
 block/nbd.c          | 796 +++++++++++++++++++++++++------------------
 3 files changed, 479 insertions(+), 330 deletions(-)
Signature · 1 line
2.49.0