Skip to content

Enhancements to the secvar interface in static key management mode

Srish Srinivasan linux-integrity linuxppc-dev lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 3 repliesIn review
  2. v33 patches 0 repliesSuperseded
  3. v23 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches16 repliesSuperseded

Changes in v4 from the cover letter

* Patch 2:

- Changes to the documentation and the patch description based on feedback from Michal.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3powerpc/pseries: Correct secvar format representation for static key managementDocumentation/ABI/testing/sysfs-secvar arch/powerpc/platforms/pseries/plpks-secvar.c+53 -331 reply
2/3powerpc/secvar: Expose secvars relevant to the key management modeDocumentation/ABI/testing/sysfs-secvar arch/powerpc/platforms/pseries/plpks-secvar.c+31 -41 reply
3/3integrity/platform_certs: Allow loading of keys in the static key management modesecurity/integrity/platform_certs/load_powerpc.c+3 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMimi ZoharStefan BergerNayna JainAndrew DonnellanR Nageswara Sastry
1/3R-b R-b R-b R-b T-b
2/3R-b R-b R-b R-b T-b
3/3R-b R-b R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/3] Enhancements to the secvar interface in static key management mode

The PLPKS enabled Power LPAR sysfs exposes all of the secure boot secure variables irrespective of the key management mode. There is support for both static and dynamic key management and the key management mode can be updated using the management console. The user should be able to read from and write to the secure boot secvars db, dbx, grubdb, grubdbx, and sbat only in the dynamic managememnt key mode. But the sysfs interface exposes these secvars even in the static key management mode even though they are not getting consumed in this mode.

Update the secvar format property based on the key management mode and expose only the secure variables relevant to the key management mode. Enable loading of signed third-party kernel modules in the static key mode when the platform keystore is enabled.

Changelog:

v4:

* Patch 2:

- Changes to the documentation and the patch description based on feedback from Michal.

v3:

* Patch 1:

- Minor changes to the docmentation based on feedback from Andrew.
- Added reviewed-by from Andrew.

v2:

* Patch 1:

- Updated plpks_get_sb_keymgmt_mode to handle -ENOENT and -EPERM in the case of static key management mode, based on feedback from Andrew.
- Moved the documentation changes relevant to the secvar format property from Patch 2 to Patch 1.
- Added reviewed-by from Nayna.

* Patch 2:

- Moved the documentaton changes relevant to secure variables from /sys/firmware/secvar/format to /sys/firmware/secvar/vars/<variable name>.
- Added reviewed-by from Nayna and Andrew.

* Patch 3:
- Added reviewed-by from Nayna and Andrew.

Srish Srinivasan (3):
powerpc/pseries: Correct secvar format representation for static key
management
powerpc/secvar: Expose secvars relevant to the key management mode integrity/platform_certs: Allow loading of keys in the static key
management mode

 Documentation/ABI/testing/sysfs-secvar        |  17 ++-
 arch/powerpc/platforms/pseries/plpks-secvar.c | 104 ++++++++++++------
 .../integrity/platform_certs/load_powerpc.c   |   5 +-
 3 files changed, 87 insertions(+), 39 deletions(-)
Signature · 1 line
2.47.1