Skip to content

PCI: endpoint: IRQ callback fixes and cleanups

Niklas Cassel linux-arm-kernel linux-pci linux-renesas-soc linux-rockchip stable 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 1 replyApplied
  2. v26 patches 7 repliesSuperseded
  3. v12 patches 9 repliesSuperseded

Changes in v3 from the cover letter

-Reorder patches to have more logical ordering
-Capitalize first letter after prefix (Krzysztof)
-Improved commit message of the cleanup patches (Damien) -Renamed parameter interrupts to nr_irqs (Damien)
-Picked up tags. Did not pick up tags on patches that changed significantly

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/6PCI: dwc: ep: Fix broken set_msix() callbackdrivers/pci/controller/dwc/pcie-designware-ep.c+3 -20 replies
2/6PCI: cadence-ep: Fix broken set_msix() callbackdrivers/pci/controller/cadence/pcie-cadence-ep.c+3 -20 replies
3/6PCI: endpoint: Cleanup get_msi() callbackdrivers/pci/controller/cadence/pcie-cadence-ep.c drivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/controller/pcie-rcar-ep.c +2 more+5 -70 replies
4/6PCI: endpoint: Cleanup get_msix() callbackdrivers/pci/controller/cadence/pcie-cadence-ep.c drivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/endpoint/pci-epc-core.c+3 -30 replies
5/6PCI: endpoint: Cleanup set_msi() callbackdrivers/pci/controller/cadence/pcie-cadence-ep.c drivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/controller/pcie-rcar-ep.c +3 more+17 -180 replies
6/6PCI: endpoint: Cleanup set_msix() callbackdrivers/pci/controller/cadence/pcie-cadence-ep.c drivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/endpoint/pci-epc-core.c +1 more+14 -180 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchWilfred MallawaDamien Le Moal
1/6R-b R-b
2/6R-b R-b
3/6R-b
4/6R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] PCI: endpoint: IRQ callback fixes and cleanups

Hello all,

The first two patches in this series are IRQ callback fixes that should get backported.

The reason why the bugs existed in the first place is because the APIs are very confusing. The rest of the patches are cleanups of the APIs. These cleanups should not get backported.

Changes since v2:
-Reorder patches to have more logical ordering
-Capitalize first letter after prefix (Krzysztof)
-Improved commit message of the cleanup patches (Damien) -Renamed parameter interrupts to nr_irqs (Damien)
-Picked up tags. Did not pick up tags on patches that changed significantly

Niklas Cassel (6):
PCI: dwc: ep: Fix broken set_msix() callback
PCI: cadence-ep: Fix broken set_msix() callback
PCI: endpoint: Cleanup get_msi() callback
PCI: endpoint: Cleanup get_msix() callback
PCI: endpoint: Cleanup set_msi() callback
PCI: endpoint: Cleanup set_msix() callback

 .../pci/controller/cadence/pcie-cadence-ep.c  | 14 +++++-----
 .../pci/controller/dwc/pcie-designware-ep.c   | 15 ++++++-----
 drivers/pci/controller/pcie-rcar-ep.c         |  8 +++---
 drivers/pci/controller/pcie-rockchip-ep.c     |  9 ++++---
 drivers/pci/endpoint/pci-epc-core.c           | 26 +++++++------------
 include/linux/pci-epc.h                       | 11 ++++----
 6 files changed, 39 insertions(+), 44 deletions(-)
Signature · 1 line
2.49.0