Skip to content

iomap: misc buffered write path cleanups and prep

Brian Foster linux-fsdevel linux-xfs 2 versions – Applied

Status from this message: Applied to the vfs-6.16.iomap branch of the vfs/vfs.git tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyApplied
  2. v16 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- Split up warning in trim folio range helper.
- Use min() and min_not_zero() instead of open coding.
- Drop pos param from __iomap_write_begin() (folded into patch 6).
v1: https://lore.kernel.org/linux-fsdevel/[email protected]/

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6iomap: resample iter->pos after iomap_write_begin() callsfs/iomap/buffered-io.c+11 -80 replies
2/6iomap: drop unnecessary pos param from iomap_write_[begin|end]fs/iomap/buffered-io.c+12 -100 replies
3/6iomap: drop pos param from __iomap_[get|put]_folio()fs/iomap/buffered-io.c+9 -80 replies
4/6iomap: helper to trim pos/bytes to within foliofs/iomap/buffered-io.c+20 -150 replies
5/6iomap: push non-large folio check into get folio pathfs/iomap/buffered-io.c+3 -30 replies
6/6iomap: rework iomap_write_begin() to return folio offset and lengthfs/iomap/buffered-io.c+19 -140 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigDarrick J. Wong
1/6R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] iomap: misc buffered write path cleanups and prep

Hi all,

Here's a bit more fallout and prep. work associated with the folio batch prototype posted a while back [1]. Work on that is still pending so it isn't included here, but based on the iter advance cleanups most of these seemed worthwhile as standalone cleanups. Mainly this just cleans up some of the helpers and pushes some pos/len trimming further down in the write begin path.

The fbatch thing is still in prototype stage, but for context the intent here is that it can mostly now just bolt onto the folio lookup path because we can advance the range that is skipped and return the next folio along with the folio subrange for the caller to process.

Thoughts, reviews, flames appreciated.

Brian

[1] https://lore.kernel.org/linux-fsdevel/[email protected]/

v2:
- Split up warning in trim folio range helper.
- Use min() and min_not_zero() instead of open coding.
- Drop pos param from __iomap_write_begin() (folded into patch 6).
v1: https://lore.kernel.org/linux-fsdevel/[email protected]/

Brian Foster (6):
iomap: resample iter->pos after iomap_write_begin() calls
iomap: drop unnecessary pos param from iomap_write_[begin|end]
iomap: drop pos param from __iomap_[get|put]_folio()
iomap: helper to trim pos/bytes to within folio
iomap: push non-large folio check into get folio path
iomap: rework iomap_write_begin() to return folio offset and length

 fs/iomap/buffered-io.c | 100 ++++++++++++++++++++++++-----------------
 1 file changed, 58 insertions(+), 42 deletions(-)
Signature · 1 line
2.49.0