Skip to content

Panel Replay + Adaptive sync

Jouni Högander intel-xe 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest posting 2/212 patches 1 replyIn review
  2. v4 posting 1/212 patches 5 repliesSuperseded
  3. v312 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v212 patches9 repliesSuperseded
v111 patches21 repliesSuperseded

Changes in v4 from the cover letter

- added DP_DSC_DECODE_CAPABILITY definitions
- use defined shift instead of hardcoded value

Patches in v4 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/panelreplay: Panel Replay capability DPCD register definitionsdrivers/gpu/drm/i915/display/intel_psr.c include/drm/display/drm_dp.h+11 -90 replies
2/12drm/dp: Add Panel Replay capability bits from DP2.1 specificationinclude/drm/display/drm_dp.h+12 -20 replies
3/12drm/i915/psr: Read all Panel Replay capability registers from DPCDdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_psr.c+16 -80 replies
4/12drm/i915/alpm: Add PR_ALPM_CTL register definitionsdrivers/gpu/drm/i915/display/intel_psr_regs.h+10 -00 replies
5/12drm/i915/alpm: Write PR_ALPM_CTL registerdrivers/gpu/drm/i915/display/intel_alpm.c+14 -00 replies
6/12drm/i915/psr: Add interface to check if AUXLess ALPM is needed by PSRdrivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/display/intel_psr.h+8 -00 replies
7/12drm/i915/alpm: Add new interface to check if AUXLess ALPM is useddrivers/gpu/drm/i915/display/intel_alpm.c drivers/gpu/drm/i915/display/intel_alpm.h+10 -20 replies
8/12drm/i915/alpm: Move port alpm configurationdrivers/gpu/drm/i915/display/intel_alpm.c drivers/gpu/drm/i915/display/intel_alpm.h drivers/gpu/drm/i915/display/intel_cx0_phy.c +1 more+39 -180 replies
9/12drm/i915/display: Add PHY_CMN1_CONTROL register definitionsdrivers/gpu/drm/i915/display/intel_cx0_phy_regs.h+3 -00 replies
10/12drm/i915/display: Add function to configure LFPS sendingdrivers/gpu/drm/i915/display/intel_cx0_phy.c drivers/gpu/drm/i915/display/intel_cx0_phy.h drivers/gpu/drm/i915/display/intel_ddi.c+40 -11 reply
11/12drm/i915/psr: Fix using wrong mask in REG_FIELD_PREPdrivers/gpu/drm/i915/display/intel_psr_regs.h+2 -20 replies
12/12drm/i915/psr: Do not disable Panel Replay in case VRR is enableddrivers/gpu/drm/i915/display/intel_psr.c+6 -60 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchAnkit NautiyalMaarten Lankhorst
1/12R-b A-b
2/12R-b A-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/12] Panel Replay + Adaptive sync

This patch set is adding missing configuration to have Panel Replay and Adaptive Sync enabled simultaneously. Also some issues identified while debugging are fixed:

1. Source PORT ALPM configuration has to made during modeset.
2. PHY_CMN1_CONTROL is not written according to HAS document
3. Wrong register field definitions for PORT_ALPM_LFPS_CTL.

Patches are tested on LunarLake and PantherLake using our reference panel supporting Adaptive Sync and Panel Replay.

No changes. Resending to [email protected] as previously it wasn't testest by Xe CI at all.

v4:
- added DP_DSC_DECODE_CAPABILITY definitions
- use defined shift instead of hardcoded value
v3:
- comment about DP2.1 corrected as DP2.1a
- referring patch removed from commit message
v2:
- rework Panel Replay DPCD register definitions
- do not use hardcoded indices while accessing intel_dp->pr_dpcd
- ensure ALPM registers are not written on platform where they do not exist
- remove kerneldoc comments

Jouni Högander (12):
drm/panelreplay: Panel Replay capability DPCD register definitions drm/dp: Add Panel Replay capability bits from DP2.1 specification drm/i915/psr: Read all Panel Replay capability registers from DPCD drm/i915/alpm: Add PR_ALPM_CTL register definitions drm/i915/alpm: Write PR_ALPM_CTL register
drm/i915/psr: Add interface to check if AUXLess ALPM is needed by PSR drm/i915/alpm: Add new interface to check if AUXLess ALPM is used drm/i915/alpm: Move port alpm configuration drm/i915/display: Add PHY_CMN1_CONTROL register definitions drm/i915/display: Add function to configure LFPS sending drm/i915/psr: Fix using wrong mask in REG_FIELD_PREP drm/i915/psr: Do not disable Panel Replay in case VRR is enabled

 drivers/gpu/drm/i915/display/intel_alpm.c     | 72 +++++++++++++------
 drivers/gpu/drm/i915/display/intel_alpm.h     |  4 ++
 drivers/gpu/drm/i915/display/intel_cx0_phy.c  | 32 +++++++++
 drivers/gpu/drm/i915/display/intel_cx0_phy.h  |  2 +
 .../gpu/drm/i915/display/intel_cx0_phy_regs.h |  3 +
 drivers/gpu/drm/i915/display/intel_ddi.c      | 12 ++++
 .../drm/i915/display/intel_display_types.h    |  4 +-
 drivers/gpu/drm/i915/display/intel_psr.c      | 44 +++++++-----
 drivers/gpu/drm/i915/display/intel_psr.h      |  2 +
 drivers/gpu/drm/i915/display/intel_psr_regs.h | 14 +++-
 include/drm/display/drm_dp.h                  | 24 +++++--
 11 files changed, 168 insertions(+), 45 deletions(-)
Signature · 1 line
2.43.0