Skip to content

drm/xe/ggtt: Stop relying on GGTT internals.

Maarten Lankhorst intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/xe: Use xe_ggtt_map_bo_unlocked for resumedrivers/gpu/drm/xe/xe_bo_evict.c drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h+17 -50 replies
2/10drm/xe: Add xe_ggtt_might_lockdrivers/gpu/drm/xe/xe_bo.c drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h+15 -10 replies
3/10drm/xe: Add xe_ggtt_allocdrivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h drivers/gpu/drm/xe/xe_tile.c+19 -50 replies
4/10drm/xe/display: Remove dereferences of ggtt for tile iddrivers/gpu/drm/xe/display/xe_fb_pin.c+7 -61 reply
5/10drm/xe/ggtt: Seperate flags and address in PTE encodingdrivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h drivers/gpu/drm/xe/xe_ggtt_types.h+65 -273 replies
6/10drm/xe/display: Dont poke into GGTT internals to fill a DPTdrivers/gpu/drm/xe/display/xe_fb_pin.c drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h+26 -111 reply
7/10drm/xe/display: Convert GGTT mapping to use pte_encode_flagsdrivers/gpu/drm/xe/display/xe_fb_pin.c+5 -121 reply
8/10drm/xe: Remove pte_encode_bo callbackdrivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt_types.h+0 -171 reply
9/10drm/xe: Implement a helper for reading out a GGTT PTE at a specified offsetdrivers/gpu/drm/xe/display/xe_plane_initial.c drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h+14 -51 reply
10/10drm/xe: Do not rely on GGTT internals in xe_guc_buf kunit testsdrivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h+24 -111 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchMatthew BrostLucas De MarchiJuha-Pekka Heikkila
1/10R-b R-b
2/10R-b
3/10R-b R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/10] drm/xe/ggtt: Stop relying on GGTT internals.

This patch cleans up all users of struct GGTT outside of display.

Most uses inside display have been cleaned up too, the hardest part is fixing rotated GGTT display buffers, which I've postponed for now.

Once that's fixed, no users outside of xe_ggtt.c remain, and the struct definition can be made private.

Maarten Lankhorst (10):
drm/xe: Use xe_ggtt_map_bo_unlocked for resume
drm/xe: Add xe_ggtt_might_lock
drm/xe: Add xe_ggtt_alloc
drm/xe/display: Remove dereferences of ggtt for tile id drm/xe/ggtt: Seperate flags and address in PTE encoding drm/xe/display: Dont poke into GGTT internals to fill a DPT drm/xe/display: Convert GGTT mapping to use pte_encode_flags drm/xe: Remove pte_encode_bo callback
drm/xe: Implement a helper for reading out a GGTT PTE at a specified
offset
drm/xe: Do not rely on GGTT internals in xe_guc_buf kunit tests

 drivers/gpu/drm/xe/display/xe_fb_pin.c        |  50 +++---
 drivers/gpu/drm/xe/display/xe_plane_initial.c |   6 +-
 drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c   |  11 +-
 drivers/gpu/drm/xe/xe_bo.c                    |   2 +-
 drivers/gpu/drm/xe/xe_bo_evict.c              |   4 +-
 drivers/gpu/drm/xe/xe_ggtt.c                  | 156 ++++++++++++++----
 drivers/gpu/drm/xe/xe_ggtt.h                  |  17 +-
 drivers/gpu/drm/xe/xe_ggtt_types.h            |   4 +-
 drivers/gpu/drm/xe/xe_tile.c                  |   6 +-
 9 files changed, 174 insertions(+), 82 deletions(-)
Signature · 1 line
2.45.2