Skip to content

Avoid submodule overwritten and skip redundant active entries

K Jayatheerth git 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest2 patches 8 repliesIn review
  2. v7 posting 2/22 patches 5 repliesSuperseded
  3. v7 posting 1/22 patches 1 replySuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v62 patches1 replySuperseded
v51 patch4 repliesSuperseded
v41 patch1 replySuperseded
v31 patch2 repliesSuperseded
v21 patch1 replySuperseded
v11 patch3 repliesSuperseded

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2submodule: prevent overwriting .gitmodules entry on path reusebuiltin/submodule--helper.c t/t7400-submodule-basic.sh+51 -03 replies
2/2submodule: skip redundant active entries when pattern covers pathbuiltin/submodule--helper.c t/t7413-submodule-is-active.sh+36 -114 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v8 yet.

Read the v8 thread

Cover letter [PATCH v8 0/2] Avoid submodule overwritten and skip redundant active entries

The first patch i.e. prevent overwriting .gitmodules entry on path reuse is exactly the same

The second patch however i.e.
skip redundant active entries when pattern covers path has changed logic
with the helper function being code maintainance because of the duplicated logic. I've tried to wrap it as much as possible to it's own core need without having to change it unless the core way of submodules addition and active status itself changes.

The CI was tested in which
the only compiler error I found was
osx-gcc
Which I suppose is already addressed,
apart from this all of the other tests
ran successfully which includes the
t7413 (prvious 9) and the new one.

K Jayatheerth (2):
submodule: prevent overwriting .gitmodules entry on path reuse
submodule: skip redundant active entries when pattern covers path

 builtin/submodule--helper.c    | 60 +++++++++++++++++++++++++++-------
 t/t7400-submodule-basic.sh     | 23 +++++++++++++
 t/t7413-submodule-is-active.sh | 15 +++++++++
 3 files changed, 87 insertions(+), 11 deletions(-)
Signature · 1 line
2.49.GIT